From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Set pin direction properly
Date: Mon, 09 Jan 2017 17:41:52 +0200 [thread overview]
Message-ID: <1483976512.26691.37.camel@linux.intel.com> (raw)
In-Reply-To: <8e8e25bc-c5e3-e619-b12f-4b5fad1f6ab7@linux.intel.com>
On Mon, 2017-01-09 at 17:12 +0200, Jarkko Nikula wrote:
> On 01/09/2017 04:45 PM, Andy Shevchenko wrote:
> > On Mon, 2017-01-09 at 16:29 +0200, Jarkko Nikula wrote:
> > > On 01/02/2017 02:07 PM, Andy Shevchenko wrote:
> > > > There are two bits in the PADCFG0 register to configure
> > > > direction,
> > > > one per
> > > > TX/RX buffers.
> > > >
> > > > For now we wrongly assume that the GPIO is always requested
> > > > before
> > > > it is being
> > > > used, which is not true when the GPIO is used through irqchip.
> > > > In
> > > > this case the
> > > > GPIO is never requested and we never enable RX buffer for it.
> > > >
> > > > Fix this by setting both bits accordingly.
> > > >
> > > > Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > > >
> >
> >
> > > > @@ -392,18 +407,11 @@ static int intel_gpio_set_direction(struct
> > > > pinctrl_dev *pctldev,
> > >
> > > I'm testing this on top of v4.10.0-rc3 and I don't see changes in
> > > PADCFG0 after this patch. I guess reason is that the code doesn't
> > > go
> > > through above functions for the pin that is used through irqchip
> > > but
> > > through intel_gpio_irq_type().
> > >
> > > Am I missing some another patch or should your patch add
> > > __intel_gpio_set_direction() also there?
> >
> > The problem you reported about apparently discovers two places to be
> > fixed. This is part 1. Part 2 will be send with GPIO ACPI clean up /
> > bug
> > fix series later.
> >
>
> Should the commit log be refined a bit as this patch doesn't fix the
> issue but prepares for the fix by adding the RX pad control in
> intel_gpio_set_direction()?
I don't think we need this. Basically I split your Reported-by to the
two patches (okay, I need to check if I put it to another one).
The problems they solve are kinda independent, but both of them are
parts of the issue you faced.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-01-09 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 12:07 [PATCH v1 1/1] pinctrl: intel: Set pin direction properly Andy Shevchenko
2017-01-09 14:29 ` Jarkko Nikula
2017-01-09 14:45 ` Andy Shevchenko
2017-01-09 15:12 ` Jarkko Nikula
2017-01-09 15:41 ` Andy Shevchenko [this message]
2017-01-11 12:50 ` Linus Walleij
2017-01-11 14:21 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483976512.26691.37.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).