From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Cristina Ciocan <cristina.ciocan@intel.com>
Subject: Re: [PATCH v1 1/1] pinctrl: baytrail: Rectify debounce support
Date: Tue, 10 Jan 2017 16:35:36 +0200 [thread overview]
Message-ID: <1484058936.2133.23.camel@linux.intel.com> (raw)
In-Reply-To: <20170110141207.GH2330@lahna.fi.intel.com>
On Tue, 2017-01-10 at 16:12 +0200, Mika Westerberg wrote:
> On Tue, Jan 10, 2017 at 04:03:19PM +0200, Andy Shevchenko wrote:
> > The commit 658b476c742f ("pinctrl: baytrail: Add debounce
> > configuration")
> > implements debounce for Baytrail pin control, but seems wasn't
> > tested properly.
> >
> > Rectify implementation here.
>
> So what was wrong with the implementation?
It writes the wrong register.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2017-01-10 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 14:03 [PATCH v1 1/1] pinctrl: baytrail: Rectify debounce support Andy Shevchenko
2017-01-10 14:12 ` Mika Westerberg
2017-01-10 14:35 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484058936.2133.23.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=cristina.ciocan@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).