From: Keerthy <j-keerthy@ti.com>
To: linus.walleij@linaro.org, t-kristo@ti.com
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
gnurou@gmail.com, grygorii.strashko@ti.com, j-keerthy@ti.com
Subject: [PATCH V2 5/6] gpio: davinci: Remove custom .xlate
Date: Fri, 13 Jan 2017 09:50:14 +0530 [thread overview]
Message-ID: <1484281215-24576-6-git-send-email-j-keerthy@ti.com> (raw)
In-Reply-To: <1484281215-24576-1-git-send-email-j-keerthy@ti.com>
With the current redesign of driver it's not necessary to have
custom .xlate() as the gpiolib will assign default of_gpio_simple_xlate().
Suggested-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/gpio/gpio-davinci.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 2a5ae04..86b4950 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -163,27 +163,6 @@ static int davinci_gpio_get(struct gpio_chip *chip, unsigned offset)
return NULL;
}
-#ifdef CONFIG_OF_GPIO
-static int davinci_gpio_of_xlate(struct gpio_chip *gc,
- const struct of_phandle_args *gpiospec,
- u32 *flags)
-{
- struct davinci_gpio_controller *chips = dev_get_drvdata(gc->parent);
- struct davinci_gpio_platform_data *pdata = dev_get_platdata(gc->parent);
-
- if (gpiospec->args[0] > pdata->ngpio)
- return -EINVAL;
-
- if (gc != &chips->chip)
- return -EINVAL;
-
- if (flags)
- *flags = gpiospec->args[1];
-
- return gpiospec->args[0] % 32;
-}
-#endif
-
static int davinci_gpio_probe(struct platform_device *pdev)
{
static int ctrl_num, bank_base;
@@ -244,7 +223,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
#ifdef CONFIG_OF_GPIO
chips->chip.of_gpio_n_cells = 2;
- chips->chip.of_xlate = davinci_gpio_of_xlate;
chips->chip.parent = dev;
chips->chip.of_node = dev->of_node;
#endif
--
1.9.1
next prev parent reply other threads:[~2017-01-13 4:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 4:20 [PATCH V2 0/6] gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip Keerthy
2017-01-13 4:20 ` [PATCH V2 1/6] gpio: davinci: Remove gpio2regs function to accommodate multi instances Keerthy
2017-01-13 4:20 ` [PATCH V2 2/6] gpio: davinci: Remove unwanted blank line Keerthy
2017-01-13 4:20 ` [PATCH V2 3/6] gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip Keerthy
2017-01-18 23:22 ` Linus Walleij
2017-01-13 4:20 ` [PATCH V2 4/6] gpio: davinci: Add support for multiple GPIO controllers Keerthy
2017-01-13 4:20 ` Keerthy [this message]
2017-01-13 4:20 ` [PATCH V2 6/6] gpio: davinci: Remove redundant macros Keerthy
2017-01-15 4:31 ` kbuild test robot
2017-01-16 6:57 ` Keerthy
2017-01-13 18:02 ` [PATCH V2 0/6] gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484281215-24576-6-git-send-email-j-keerthy@ti.com \
--to=j-keerthy@ti.com \
--cc=gnurou@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).