From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"jdelvare@suse.de" <jdelvare@suse.de>
Cc: "Ciocan, Cristina" <cristina.ciocan@intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>
Subject: Re: Suspicious debounce handling code in pintctrl-baytrail
Date: Thu, 26 Jan 2017 14:15:21 +0000 [thread overview]
Message-ID: <1485440121.2133.344.camel@intel.com> (raw)
In-Reply-To: <1485439990.2133.343.camel@intel.com>
On Thu, 2017-01-26 at 16:13 +0200, Andy Shevchenko wrote:
> On Thu, 2017-01-26 at 15:00 +0100, Jean Delvare wrote:
> > Hi Mika, hello Andy,
> >
> > Additionally, I suspect that in the "get" path, the following is
> > > wrong:
> > >
> > > case PIN_CONFIG_INPUT_DEBOUNCE:
> > > if (!(conf & BYT_DEBOUNCE_EN))
> > > return -EINVAL;
> > >
> > > I'm not familiar with the pinctrl interface but my understanding
> > > of
> > > the PIN_CONFIG_INPUT_DEBOUNCE documentation is that the driver
> > > must
> > > return 0 if debouncing is disabled.
> >
> > ?
No, this is correct.
"...if it is available but disabled it should return -EINVAL"
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
next prev parent reply other threads:[~2017-01-26 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 13:20 Suspicious debounce handling code in pintctrl-baytrail Jean Delvare
2017-01-26 13:43 ` Mika Westerberg
2017-01-26 14:00 ` Jean Delvare
2017-01-26 14:08 ` Mika Westerberg
2017-01-26 14:24 ` Jean Delvare
2017-01-26 14:13 ` Shevchenko, Andriy
2017-01-26 14:15 ` Shevchenko, Andriy [this message]
2017-01-26 14:50 ` mika.westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485440121.2133.344.camel@intel.com \
--to=andriy.shevchenko@intel.com \
--cc=cristina.ciocan@intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).