linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dong Aisheng <aisheng.dong@nxp.com>
To: linux-gpio@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linus.walleij@linaro.org,
	shawnguo@kernel.org, stefan@agner.ch, ping.bai@nxp.com,
	fugang.duan@nxp.com, kernel@pengutronix.de,
	Dong Aisheng <aisheng.dong@nxp.com>,
	Alexandre Courbot <gnurou@gmail.com>
Subject: [PATCH 2/2] pinctrl: pinctrl-imx: do not assume mux 0 is gpio
Date: Mon, 15 May 2017 14:48:26 +0800	[thread overview]
Message-ID: <1494830906-6442-3-git-send-email-aisheng.dong@nxp.com> (raw)
In-Reply-To: <1494830906-6442-1-git-send-email-aisheng.dong@nxp.com>

Do not assume MUX 0 is GPIO function in core driver as a different
SoC may have different value. e.g. MX7ULP Mux 1 is GPIO.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Stefan Agner <stefan@agner.ch>
Cc: Fugang Duan <fugang.duan@nxp.com>
Cc: Bai Ping <ping.bai@nxp.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
 drivers/pinctrl/freescale/pinctrl-imx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index 0d6aaca..ed8ea32 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -281,7 +281,7 @@ static int imx_pmx_gpio_request_enable(struct pinctrl_dev *pctldev,
 			continue;
 		for (pin = 0; pin < grp->num_pins; pin++) {
 			imx_pin = &((struct imx_pin *)(grp->data))[pin];
-			if (imx_pin->pin == offset && !imx_pin->mux_mode)
+			if (imx_pin->pin == offset)
 				goto mux_pin;
 		}
 	}
@@ -292,6 +292,7 @@ static int imx_pmx_gpio_request_enable(struct pinctrl_dev *pctldev,
 	reg = readl(ipctl->base + pin_reg->mux_reg);
 	reg &= ~info->mux_mask;
 	reg |= imx_pin->config;
+	reg |= imx_pin->mux_mode << info->mux_shift;
 	writel(reg, ipctl->base + pin_reg->mux_reg);
 
 	return 0;
-- 
2.7.4


  parent reply	other threads:[~2017-05-15  6:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15  6:48 [PATCH 0/2] pinctrl: pinctrl-imx: add gpio support for mx7ulp Dong Aisheng
2017-05-15  6:48 ` [PATCH 1/2] pinctrl: pinctrl-imx: add IBE and OBE SoC property Dong Aisheng
2017-05-15 17:10   ` Stefan Agner
2017-05-17  6:13     ` A.S. Dong
2017-05-23 12:06     ` A.S. Dong
2017-05-23 19:16       ` Stefan Agner
2017-05-24  5:48         ` A.S. Dong
2017-05-24  8:59           ` Lothar Waßmann
2017-05-15  6:48 ` Dong Aisheng [this message]
2017-05-15 17:27   ` [PATCH 2/2] pinctrl: pinctrl-imx: do not assume mux 0 is gpio Stefan Agner
2017-05-17  7:18     ` A.S. Dong
2017-05-17 18:16       ` Stefan Agner
2017-05-18  7:00         ` A.S. Dong
2017-05-23 10:23         ` A.S. Dong
2017-05-23 19:55           ` Stefan Agner
2017-05-24  5:40             ` A.S. Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494830906-6442-3-git-send-email-aisheng.dong@nxp.com \
    --to=aisheng.dong@nxp.com \
    --cc=fugang.duan@nxp.com \
    --cc=gnurou@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=ping.bai@nxp.com \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).