From: Sylvain Lemieux <slemieux.tyco@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Sebastian Reichel <sre@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Steven Miao <realmz6@gmail.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.co.uk>,
linux-gpio@vger.kernel.org,
adi-buildroot-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 01/14] gpio: mcp23s08: move to pinctrl
Date: Tue, 16 May 2017 15:45:58 -0400 [thread overview]
Message-ID: <1494963958.29644.2.camel@gmail.com> (raw)
In-Reply-To: <20170515092438.13076-2-sebastian.reichel@collabora.co.uk>
On Mon, 2017-05-15 at 11:24 +0200, Sebastian Reichel wrote:
> This moves the mcp23s08 driver from gpio to pinctrl. Actual
> pinctrl support for configuration of the pull-up resistors
> follows in its own patch.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> ---
> arch/arm/configs/lpc32xx_defconfig | 2 +-
> arch/blackfin/configs/BF609-EZKIT_defconfig | 2 +-
> arch/blackfin/mach-bf527/boards/tll6527m.c | 4 ++--
> arch/blackfin/mach-bf609/boards/ezkit.c | 4 ++--
> drivers/gpio/Kconfig | 17 -----------------
> drivers/gpio/Makefile | 1 -
> drivers/pinctrl/Kconfig | 13 +++++++++++++
> drivers/pinctrl/Makefile | 1 +
> .../gpio-mcp23s08.c => pinctrl/pinctrl-mcp23s08.c} | 0
> 9 files changed, 20 insertions(+), 24 deletions(-)
> rename drivers/{gpio/gpio-mcp23s08.c => pinctrl/pinctrl-mcp23s08.c} (100%)
>
> diff --git a/arch/arm/configs/lpc32xx_defconfig b/arch/arm/configs/lpc32xx_defconfig
> index 6ba430d2b5b2..e15fa5f168bb 100644
> --- a/arch/arm/configs/lpc32xx_defconfig
> +++ b/arch/arm/configs/lpc32xx_defconfig
> @@ -112,7 +112,7 @@ CONFIG_GPIO_SX150X=y
> CONFIG_GPIO_74X164=y
> CONFIG_GPIO_MAX7301=y
> CONFIG_GPIO_MC33880=y
> -CONFIG_GPIO_MCP23S08=y
> +CONFIG_PINCTRL_MCP23S08=y
> CONFIG_SENSORS_DS620=y
> CONFIG_SENSORS_MAX6639=y
> CONFIG_WATCHDOG=y
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
[...]
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 23ca51ee6b28..5f88d7324e02 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1227,23 +1227,6 @@ config GPIO_PISOSR
>
> endmenu
>
> -menu "SPI or I2C GPIO expanders"
> - depends on (SPI_MASTER && !I2C) || I2C
> -
> -config GPIO_MCP23S08
> - tristate "Microchip MCP23xxx I/O expander"
> - depends on OF_GPIO
> - select GPIOLIB_IRQCHIP
> - select REGMAP_I2C if I2C
> - select REGMAP if SPI_MASTER
> - help
> - SPI/I2C driver for Microchip MCP23S08/MCP23S17/MCP23008/MCP23017
> - I/O expanders.
> - This provides a GPIO interface supporting inputs and outputs.
> - The I2C versions of the chips can be used as interrupt-controller.
> -
> -endmenu
> -
> menu "USB GPIO expanders"
> depends on USB
>
> diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> index 68b96277d9fa..89f10061a5c1 100644
> --- a/drivers/gpio/Makefile
> +++ b/drivers/gpio/Makefile
> @@ -77,7 +77,6 @@ obj-$(CONFIG_GPIO_MENZ127) += gpio-menz127.o
> obj-$(CONFIG_GPIO_MERRIFIELD) += gpio-merrifield.o
> obj-$(CONFIG_GPIO_MC33880) += gpio-mc33880.o
> obj-$(CONFIG_GPIO_MC9S08DZ60) += gpio-mc9s08dz60.o
> -obj-$(CONFIG_GPIO_MCP23S08) += gpio-mcp23s08.o
> obj-$(CONFIG_GPIO_ML_IOH) += gpio-ml-ioh.o
> obj-$(CONFIG_GPIO_MM_LANTIQ) += gpio-mm-lantiq.o
> obj-$(CONFIG_GPIO_MOCKUP) += gpio-mockup.o
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 37af5e3029d5..b5aa50c51633 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -146,6 +146,19 @@ config PINCTRL_FALCON
> depends on SOC_FALCON
> depends on PINCTRL_LANTIQ
>
> +config PINCTRL_MCP23S08
> + tristate "Microchip MCP23xxx I/O expander"
> + depends on OF_GPIO
> + depends on SPI_MASTER || I2C
> + select GPIOLIB_IRQCHIP
> + select REGMAP_I2C if I2C
> + select REGMAP_SPI if SPI_MASTER
> + help
> + SPI/I2C driver for Microchip MCP23S08/MCP23S17/MCP23008/MCP23017
> + I/O expanders.
> + This provides a GPIO interface supporting inputs and outputs.
> + The I2C versions of the chips can be used as interrupt-controller.
> +
> config PINCTRL_MESON
> bool
> depends on OF
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> index 0e9b2226a7c2..59d793aa3db3 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -19,6 +19,7 @@ obj-$(CONFIG_PINCTRL_DA850_PUPD) += pinctrl-da850-pupd.o
> obj-$(CONFIG_PINCTRL_DIGICOLOR) += pinctrl-digicolor.o
> obj-$(CONFIG_PINCTRL_FALCON) += pinctrl-falcon.o
> obj-$(CONFIG_PINCTRL_MAX77620) += pinctrl-max77620.o
> +obj-$(CONFIG_PINCTRL_MCP23S08) += pinctrl-mcp23s08.o
> obj-$(CONFIG_PINCTRL_MESON) += meson/
> obj-$(CONFIG_PINCTRL_OXNAS) += pinctrl-oxnas.o
> obj-$(CONFIG_PINCTRL_PALMAS) += pinctrl-palmas.o
> diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
> similarity index 100%
> rename from drivers/gpio/gpio-mcp23s08.c
> rename to drivers/pinctrl/pinctrl-mcp23s08.c
next prev parent reply other threads:[~2017-05-16 19:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 9:24 [PATCHv3 00/14] mcp23s08 pinconf & cleanup Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 01/14] gpio: mcp23s08: move to pinctrl Sebastian Reichel
2017-05-16 19:45 ` Sylvain Lemieux [this message]
2017-05-15 9:24 ` [PATCHv3 02/14] pinctrl: mcp23s08: add pinconf support Sebastian Reichel
2017-05-15 12:34 ` Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 03/14] pinctrl: mcp23s08: drop pullup config from pdata Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 04/14] pinctrl: mcp23s08: switch to regmap caching Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 05/14] pinctrl: mcp23s08: drop OF_GPIO dependency Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 06/14] pinctrl: mcp23s08: irq mapping is already done Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 07/14] pinctrl: mcp23s08: use managed kzalloc for mcp Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 08/14] pinctrl: mcp23s08: switch to devm_gpiochip_add_data Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 09/14] pinctrl: mcp23s08: simplify i2c pdata handling Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 10/14] pinctrl: mcp23s08: simplify spi " Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 11/14] pinctrl: mcp23s08: generalize irq property handling Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 12/14] pinctrl: mcp23s08: simplify spi_present_mask handling Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 13/14] pinctrl: mcp23s08: drop comment about missing irq support Sebastian Reichel
2017-05-15 9:24 ` [PATCHv3 14/14] pinctrl: mcp23s08: fix comment for mcp23s08_platform_data.base Sebastian Reichel
2017-05-23 7:55 ` [PATCHv3 00/14] mcp23s08 pinconf & cleanup Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494963958.29644.2.camel@gmail.com \
--to=slemieux.tyco@gmail.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=enric.balletbo@collabora.co.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=realmz6@gmail.com \
--cc=sebastian.reichel@collabora.co.uk \
--cc=sre@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).