From: Jerome Brunet <jbrunet@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>, linus.walleij@linaro.org
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] pinctrl: meson-gxl: Fix typo in AO I2S pins
Date: Wed, 24 May 2017 10:41:11 +0200 [thread overview]
Message-ID: <1495615271.14589.6.camel@baylibre.com> (raw)
In-Reply-To: <1495614042-2676-2-git-send-email-narmstrong@baylibre.com>
On Wed, 2017-05-24 at 10:20 +0200, Neil Armstrong wrote:
> The AO I2S pins were incorrectly defined with the EE pin offset.
Thx for catching this!
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Fixes: 2899adf0422 ("pinctrl: meson: gxl: add i2s output pins")
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/pinctrl/meson/pinctrl-meson-gxl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> index 719ff1b..9af8e6a 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> @@ -276,8 +276,8 @@
> static const unsigned int pwm_ao_b_pins[] = { PIN(GPIOAO_9, 0) };
> static const unsigned int pwm_ao_b_6_pins[] = { PIN(GPIOAO_6, 0) };
>
> -static const unsigned int i2s_out_ch23_ao_pins[] = { PIN(GPIOAO_8, EE_OFF) };
> -static const unsigned int i2s_out_ch45_ao_pins[] = { PIN(GPIOAO_9, EE_OFF) };
> +static const unsigned int i2s_out_ch23_ao_pins[] = { PIN(GPIOAO_8, 0) };
> +static const unsigned int i2s_out_ch45_ao_pins[] = { PIN(GPIOAO_9, 0) };
>
> static const unsigned int spdif_out_ao_6_pins[] = { PIN(GPIOAO_6,
> EE_OFF) };
> static const unsigned int spdif_out_ao_9_pins[] = { PIN(GPIOAO_9,
> EE_OFF) };
next prev parent reply other threads:[~2017-05-24 8:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 8:20 [PATCH 0/5] pinctrl: meson: new pins and fixes round 2 Neil Armstrong
2017-05-24 8:20 ` [PATCH 1/5] pinctrl: meson-gxl: Fix typo in AO I2S pins Neil Armstrong
2017-05-24 8:41 ` Jerome Brunet [this message]
2017-05-29 8:57 ` Linus Walleij
2017-05-24 8:20 ` [PATCH 2/5] pinctrl: meson-gxl: Fix typo in AO SPDIF pins Neil Armstrong
2017-05-24 8:42 ` Jerome Brunet
2017-05-29 8:58 ` Linus Walleij
2017-05-24 8:20 ` [PATCH 3/5] pinctrl: meson-gxbb: Add CEC pins Neil Armstrong
2017-05-24 8:53 ` Jerome Brunet
2017-05-29 8:59 ` Linus Walleij
2017-05-24 8:20 ` [PATCH 4/5] pinctrl: meson-gxl: " Neil Armstrong
2017-05-24 8:54 ` Jerome Brunet
2017-05-29 9:00 ` Linus Walleij
2017-05-24 8:20 ` [PATCH 5/5] pinctrl: meson-gxl: Add Ethernet PHY LEDS pins Neil Armstrong
2017-05-24 8:57 ` Jerome Brunet
2017-05-29 9:01 ` Linus Walleij
2017-05-29 9:17 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495615271.14589.6.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).