From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [PATCH 1/5] pinctrl: meson-gxl: Fix typo in AO I2S pins Date: Wed, 24 May 2017 10:41:11 +0200 Message-ID: <1495615271.14589.6.camel@baylibre.com> References: <1495614042-2676-1-git-send-email-narmstrong@baylibre.com> <1495614042-2676-2-git-send-email-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1495614042-2676-2-git-send-email-narmstrong@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org To: Neil Armstrong , linus.walleij@linaro.org Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-gpio@vger.kernel.org On Wed, 2017-05-24 at 10:20 +0200, Neil Armstrong wrote: > The AO I2S pins were incorrectly defined with the EE pin offset. Thx for catching this! Reviewed-by: Jerome Brunet > > Cc: Jerome Brunet > Fixes: 2899adf0422 ("pinctrl: meson: gxl: add i2s output pins") > Signed-off-by: Neil Armstrong > --- >  drivers/pinctrl/meson/pinctrl-meson-gxl.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c > b/drivers/pinctrl/meson/pinctrl-meson-gxl.c > index 719ff1b..9af8e6a 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c > +++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c > @@ -276,8 +276,8 @@ >  static const unsigned int pwm_ao_b_pins[] = { PIN(GPIOAO_9, 0) }; >  static const unsigned int pwm_ao_b_6_pins[] = { PIN(GPIOAO_6, 0) }; >   > -static const unsigned int i2s_out_ch23_ao_pins[] = { PIN(GPIOAO_8, EE_OFF) }; > -static const unsigned int i2s_out_ch45_ao_pins[] = { PIN(GPIOAO_9, EE_OFF) }; > +static const unsigned int i2s_out_ch23_ao_pins[] = { PIN(GPIOAO_8, 0) }; > +static const unsigned int i2s_out_ch45_ao_pins[] = { PIN(GPIOAO_9, 0) }; >   >  static const unsigned int spdif_out_ao_6_pins[] = { PIN(GPIOAO_6, > EE_OFF) }; >  static const unsigned int spdif_out_ao_9_pins[] = { PIN(GPIOAO_9, > EE_OFF) };