From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] sh-pfc: handle pin array holes in sh_pfc_map_pins() Date: Fri, 06 Mar 2015 12:58:31 +0200 Message-ID: <1498074.6jEVhizFNe@avalon> References: <1528110.Mb5xiNU0rc@wasted.cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:33632 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755853AbbCFK60 (ORCPT ); Fri, 6 Mar 2015 05:58:26 -0500 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Sergei Shtylyov , "linux-sh@vger.kernel.org" , "linux-gpio@vger.kernel.org" Hi Linus, On Friday 06 March 2015 11:43:45 Linus Walleij wrote: > On Sat, Feb 28, 2015 at 12:39 AM, Sergei Shtylyov wrote: > > The pin array handled by sh_pfc_map_pins() may contain holes representing > > non- existing pins. We have to first count the valid pins in order to > > calculate the size of the memory to be allocated, then to skip over the > > non-existing pins when initializing the allocated arrays, and then to > > return the number of valid pins from sh_pfc_map_pins() instead of 0 on > > success. > > > > As we have to touch devm_kzalloc() calls anyway, use more fitting > > devm_kcalloc() instead which additionally checks the array size. And > > since PINMUX_TYPE_NONE is #define'd as 0, stop re-initializing already > > zeroed out 'pmx->configs' array. > > > > Signed-off-by: Sergei Shtylyov > > > > --- > > The patch is against the 'devel' branch of Linus W.'s 'linux-pinctrl.git' > > repo. This patch should be applied before my R8A7794 PFC support patch > > and before Laurent's patches removing non-existent GPIOs for R8A779[01], > > otherwise they would cause the kernel to hang while booting! > > OK not applying this until ACKed by Laurent, > and in the meantime I'm taking the three applied R8A7794 patches > out of my tree again. Could you also drop "pinctrl: sh-pfc: r8a7790: Remove non existing GPIO pins" and "pinctrl: sh-pfc: r8a7791: Remove non existing GPIO pins" for the same reason ? Sorry for the trouble. > Can you please send these depending patches as a series with this > patch as 1/4 and the three R8A7794 patches as 2,3,4/4? Thanks. -- Regards, Laurent Pinchart