From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] gpio: acpi: Skip _AEI entries without a handler rather then aborting the scan
Date: Tue, 27 Jun 2017 12:12:09 +0300 [thread overview]
Message-ID: <1498554729.22624.178.camel@linux.intel.com> (raw)
In-Reply-To: <20170626160814.GO629@lahna.fi.intel.com>
On Mon, 2017-06-26 at 19:08 +0300, Mika Westerberg wrote:
> On Fri, Jun 23, 2017 at 09:26:13AM +0200, Hans de Goede wrote:
> > acpi_walk_resources will stop as soon as the callback passed in
> > returns
> > an error status. On a x86 tablet I have the first GpioInt in the
> > _AEI
> > resource list has no handler defined in the DSDT, causing
> > acpi_walk_resources to abort scanning the rest of the resource list,
> > which does define valid ACPI GPIO events.
> >
> > This commit changes the return for not finding a handler from
> > AE_BAD_PARAMETER to AE_OK so that the rest of the resource list will
> > get scanned normally in case of missing event handlers.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
(based on private discussion with Mika)
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-06-27 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 7:26 [PATCH] gpio: acpi: Skip _AEI entries without a handler rather then aborting the scan Hans de Goede
2017-06-26 16:08 ` Mika Westerberg
2017-06-27 9:12 ` Andy Shevchenko [this message]
2017-06-29 12:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498554729.22624.178.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).