From: Philipp Rosenberger <p.rosenberger@linutronix.de>
To: linus.walleij@linaro.org, gnurou@gmail.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, Philipp Rosenberger <p.rosenberger@linutronix.de>
Subject: [PATCH 0/2] gpio-mxc: Fix issue with gpios used as wake source on iMX27
Date: Wed, 12 Jul 2017 10:36:38 +0200 [thread overview]
Message-ID: <1499848600-7233-1-git-send-email-p.rosenberger@linutronix.de> (raw)
The gpio-mxc driver is able to use two interrupts per gpio bank. One for
the lower 16 and the other for the higher 16 gpios. The iMX27 has only one
interrupt per bank. An error in the driver leads to the problem that the
driver uses an invalid interrupt for the higher 16 gpios. Which in turn
prevents the upper 16 gpios per bank to be used as wake source.
The first patch fixes the assignment for the irq_high. The second patch
adds proper return values. Which should make finding any problems in the
future much easier.
Philipp Rosenberger (2):
gpio: gpio-mxc: Fix: higher 16 GPIOs usable as wake source
gpio: gpio-mxc: gpio_set_wake_irq() use proper return values
drivers/gpio/gpio-mxc.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
--
2.1.4
next reply other threads:[~2017-07-12 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 8:36 Philipp Rosenberger [this message]
2017-07-12 8:36 ` [PATCH 1/2] gpio: gpio-mxc: Fix: higher 16 GPIOs usable as wake source Philipp Rosenberger
2017-08-01 8:37 ` Linus Walleij
2017-07-12 8:36 ` [PATCH 2/2] gpio: gpio-mxc: gpio_set_wake_irq() use proper return values Philipp Rosenberger
2017-08-01 8:39 ` Linus Walleij
2017-07-27 20:17 ` [PATCH 0/2] gpio-mxc: Fix issue with gpios used as wake source on iMX27 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499848600-7233-1-git-send-email-p.rosenberger@linutronix.de \
--to=p.rosenberger@linutronix.de \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).