From: "Nuno Sá" <noname.nuno@gmail.com>
To: ziniu.wang_1@nxp.com, laurent.pinchart@ideasonboard.com,
ukleinek@kernel.org, nuno.sa@analog.com, lee@kernel.org
Cc: linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH] pwm: adp5585: correct mismatched pwm chip info
Date: Fri, 14 Nov 2025 08:50:12 +0000 [thread overview]
Message-ID: <149fcf8e5df47fd94f9596498e9bfd7171cc7c5c.camel@gmail.com> (raw)
In-Reply-To: <20251114065308.2074893-1-ziniu.wang_1@nxp.com>
On Fri, 2025-11-14 at 14:53 +0800, ziniu.wang_1@nxp.com wrote:
> From: Luke Wang <ziniu.wang_1@nxp.com>
>
> The register addresses of ADP5585 and ADP5589 are reversed.
>
> Fixes: 75024f97e82e ("pwm: adp5585: add support for adp5589")
>
> Signed-off-by: Luke Wang <ziniu.wang_1@nxp.com>
> ---
Ouch!
Thanks for the fix!
Acked-by: Nuno Sá <nuno.sa@analog.com>
>
> drivers/pwm/pwm-adp5585.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-adp5585.c b/drivers/pwm/pwm-adp5585.c
> index dc2860979e24..806f8d79b0d7 100644
> --- a/drivers/pwm/pwm-adp5585.c
> +++ b/drivers/pwm/pwm-adp5585.c
> @@ -190,13 +190,13 @@ static int adp5585_pwm_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static const struct adp5585_pwm_chip adp5589_pwm_chip_info = {
> +static const struct adp5585_pwm_chip adp5585_pwm_chip_info = {
> .pwm_cfg = ADP5585_PWM_CFG,
> .pwm_offt_low = ADP5585_PWM_OFFT_LOW,
> .pwm_ont_low = ADP5585_PWM_ONT_LOW,
> };
>
> -static const struct adp5585_pwm_chip adp5585_pwm_chip_info = {
> +static const struct adp5585_pwm_chip adp5589_pwm_chip_info = {
> .pwm_cfg = ADP5589_PWM_CFG,
> .pwm_offt_low = ADP5589_PWM_OFFT_LOW,
> .pwm_ont_low = ADP5589_PWM_ONT_LOW,
next prev parent reply other threads:[~2025-11-14 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 6:53 [PATCH] pwm: adp5585: correct mismatched pwm chip info ziniu.wang_1
2025-11-14 7:58 ` Liu Ying
2025-11-14 8:50 ` Nuno Sá [this message]
2025-11-14 9:30 ` Uwe Kleine-König
2025-11-14 9:46 ` Nuno Sá
2025-11-14 11:03 ` Uwe Kleine-König
2025-11-18 5:17 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149fcf8e5df47fd94f9596498e9bfd7171cc7c5c.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=imx@lists.linux.dev \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ukleinek@kernel.org \
--cc=ziniu.wang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox