[PATCH] mfd: intel_soc_pmic_crc: Uniquify device name

[PATCH] mfd: intel_soc_pmic_crc: Uniquify device name

[Bastien Nocera]

---
 drivers/mfd/intel_soc_pmic_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
index 4a7494872da2..f47dadaf644c 100644
--- a/drivers/mfd/intel_soc_pmic_crc.c
+++ b/drivers/mfd/intel_soc_pmic_crc.c
@@ -147,7 +147,7 @@ static const struct regmap_irq crystal_cove_irqs[] = {
 };
 
 static const struct regmap_irq_chip crystal_cove_irq_chip = {
-	.name = "Crystal Cove",
+	.name = "Crystal Cove (PMIC)",
 	.irqs = crystal_cove_irqs,
 	.num_irqs = ARRAY_SIZE(crystal_cove_irqs),
 	.num_regs = 1,
-- 
2.13.0

Re: [PATCH] mfd: intel_soc_pmic_crc: Uniquify device name

[Lee Jones]

The commit log should not be empty.

Please provide information as to why this change is required, etc.

> ---
>  drivers/mfd/intel_soc_pmic_crc.c | 2 +-

One of the Intel guys should take a look at this too.

>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
> index 4a7494872da2..f47dadaf644c 100644
> --- a/drivers/mfd/intel_soc_pmic_crc.c
> +++ b/drivers/mfd/intel_soc_pmic_crc.c
> @@ -147,7 +147,7 @@ static const struct regmap_irq crystal_cove_irqs[] = {
>  };
>  
>  static const struct regmap_irq_chip crystal_cove_irq_chip = {
> -	.name = "Crystal Cove",
> +	.name = "Crystal Cove (PMIC)",
>  	.irqs = crystal_cove_irqs,
>  	.num_irqs = ARRAY_SIZE(crystal_cove_irqs),
>  	.num_regs = 1,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: intel_soc_pmic_crc: Uniquify device name

[Bastien Nocera]

On Mon, 2017-07-17 at 12:58 +0100, Lee Jones wrote:
> The commit log should not be empty.

Fair.

> Please provide information as to why this change is required, etc.

SSIA.

I also sent another patch to the same addresses labelled:
[PATCH] gpio: crystalcove: Uniquify driver name

Re: [PATCH] mfd: intel_soc_pmic_crc: Uniquify device name

[Lee Jones]

On Mon, 17 Jul 2017, Bastien Nocera wrote:

> On Mon, 2017-07-17 at 12:58 +0100, Lee Jones wrote:
> > The commit log should not be empty.
> 
> Fair.
> 
> > Please provide information as to why this change is required, etc.
> 
> SSIA.

Disagree.  The $SUBJECT says what your intention is, but does not
describe why it's required or what tangible difference it makes to a
running system.

> I also sent another patch to the same addresses labelled:
> [PATCH] gpio: crystalcove: Uniquify driver name

Okay?  I did wonder why the GPIO list was Cc'ed on this patch.

In this case the Intel guys are not listed as Maintainers for these
files, so you'll have to run ./get_maintainer.pl and pick them from
the committers entries.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog