From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arvind Yadav Subject: [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf Date: Wed, 20 Sep 2017 12:43:08 +0530 Message-ID: <1505891589-6632-2-git-send-email-arvind.yadav.cs@gmail.com> References: <1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com> Return-path: In-Reply-To: <1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: gregory.0xf0@gmail.com, linus.walleij@linaro.org, computersforpeace@gmail.com, f.fainelli@gmail.com Cc: bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-gpio@vger.kernel.org devm_kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/gpio/gpio-brcmstb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c index dd0308c..1227d6e 100644 --- a/drivers/gpio/gpio-brcmstb.c +++ b/drivers/gpio/gpio-brcmstb.c @@ -485,6 +485,9 @@ static int brcmstb_gpio_probe(struct platform_device *pdev) gc->of_node = np; gc->owner = THIS_MODULE; gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node); + if (!gc->label) + goto fail; + gc->base = gpio_base; gc->of_gpio_n_cells = 2; gc->of_xlate = brcmstb_gpio_of_xlate; -- 1.9.1