* [PATCH 0/2] Handle return value of devm_kasprintf
@ 2017-09-20 7:13 Arvind Yadav
2017-09-20 7:13 ` [PATCH 1/2] gpio: brcmstb: " Arvind Yadav
2017-09-20 7:13 ` [PATCH 2/2] gpio: tb10x: " Arvind Yadav
0 siblings, 2 replies; 5+ messages in thread
From: Arvind Yadav @ 2017-09-20 7:13 UTC (permalink / raw)
To: gregory.0xf0, linus.walleij, computersforpeace, f.fainelli
Cc: bcm-kernel-feedback-list, linux-gpio, linux-arm-kernel,
linux-kernel
devm_kasprintf() can fail here and we must check its return value.
Arvind Yadav (2):
[PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf
[PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf
drivers/gpio/gpio-brcmstb.c | 3 +++
drivers/gpio/gpio-tb10x.c | 3 +++
2 files changed, 6 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf
2017-09-20 7:13 [PATCH 0/2] Handle return value of devm_kasprintf Arvind Yadav
@ 2017-09-20 7:13 ` Arvind Yadav
2017-09-21 3:24 ` Gregory Fong
2017-09-20 7:13 ` [PATCH 2/2] gpio: tb10x: " Arvind Yadav
1 sibling, 1 reply; 5+ messages in thread
From: Arvind Yadav @ 2017-09-20 7:13 UTC (permalink / raw)
To: gregory.0xf0, linus.walleij, computersforpeace, f.fainelli
Cc: bcm-kernel-feedback-list, linux-gpio, linux-arm-kernel,
linux-kernel
devm_kasprintf() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/gpio/gpio-brcmstb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index dd0308c..1227d6e 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -485,6 +485,9 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
gc->of_node = np;
gc->owner = THIS_MODULE;
gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
+ if (!gc->label)
+ goto fail;
+
gc->base = gpio_base;
gc->of_gpio_n_cells = 2;
gc->of_xlate = brcmstb_gpio_of_xlate;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf
2017-09-20 7:13 ` [PATCH 1/2] gpio: brcmstb: " Arvind Yadav
@ 2017-09-21 3:24 ` Gregory Fong
0 siblings, 0 replies; 5+ messages in thread
From: Gregory Fong @ 2017-09-21 3:24 UTC (permalink / raw)
To: Arvind Yadav
Cc: Linus Walleij, Brian Norris, Florian Fainelli,
bcm-kernel-feedback-list, linux-gpio,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Wed, Sep 20, 2017 at 12:13 AM, Arvind Yadav
<arvind.yadav.cs@gmail.com> wrote:
> devm_kasprintf() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/gpio/gpio-brcmstb.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index dd0308c..1227d6e 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -485,6 +485,9 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
> gc->of_node = np;
> gc->owner = THIS_MODULE;
> gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
> + if (!gc->label)
> + goto fail;
Please also set err to -ENOMEM.
> +
> gc->base = gpio_base;
> gc->of_gpio_n_cells = 2;
> gc->of_xlate = brcmstb_gpio_of_xlate;
> --
> 1.9.1
>
Thanks,
Gregory
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf
2017-09-20 7:13 [PATCH 0/2] Handle return value of devm_kasprintf Arvind Yadav
2017-09-20 7:13 ` [PATCH 1/2] gpio: brcmstb: " Arvind Yadav
@ 2017-09-20 7:13 ` Arvind Yadav
2017-09-21 12:14 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Arvind Yadav @ 2017-09-20 7:13 UTC (permalink / raw)
To: gregory.0xf0, linus.walleij, computersforpeace, f.fainelli
Cc: bcm-kernel-feedback-list, linux-gpio, linux-arm-kernel,
linux-kernel
devm_kasprintf() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/gpio/gpio-tb10x.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
index 091ffaa..ac6f2a9 100644
--- a/drivers/gpio/gpio-tb10x.c
+++ b/drivers/gpio/gpio-tb10x.c
@@ -193,6 +193,9 @@ static int tb10x_gpio_probe(struct platform_device *pdev)
tb10x_gpio->gc.label =
devm_kasprintf(&pdev->dev, GFP_KERNEL, "%pOF", pdev->dev.of_node);
+ if (!tb10x_gpio->gc.label)
+ return -ENOMEM;
+
tb10x_gpio->gc.parent = &pdev->dev;
tb10x_gpio->gc.owner = THIS_MODULE;
tb10x_gpio->gc.direction_input = tb10x_gpio_direction_in;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf
2017-09-20 7:13 ` [PATCH 2/2] gpio: tb10x: " Arvind Yadav
@ 2017-09-21 12:14 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2017-09-21 12:14 UTC (permalink / raw)
To: Arvind Yadav
Cc: Gregory Fong, Brian Norris, Florian Fainelli,
bcm-kernel-feedback-list, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Wed, Sep 20, 2017 at 9:13 AM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> devm_kasprintf() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-21 12:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20 7:13 [PATCH 0/2] Handle return value of devm_kasprintf Arvind Yadav
2017-09-20 7:13 ` [PATCH 1/2] gpio: brcmstb: " Arvind Yadav
2017-09-21 3:24 ` Gregory Fong
2017-09-20 7:13 ` [PATCH 2/2] gpio: tb10x: " Arvind Yadav
2017-09-21 12:14 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).