From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 1/4] Revert "gpio: set up initial state from .get_direction()" Date: Tue, 31 Oct 2017 14:34:12 +0200 Message-ID: <1509453252.10233.113.camel@linux.intel.com> References: <1509396602-1936-1-git-send-email-timur@codeaurora.org> <1509396602-1936-2-git-send-email-timur@codeaurora.org> <1509440926.10233.77.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org To: Timur Tabi , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Linus Walleij , Mika Westerberg , thierry.reding@gmail.com, Stephen Boyd , david.brown@linaro.org, andy.gross@linaro.org, Bjorn Andersson List-Id: linux-gpio@vger.kernel.org On Tue, 2017-10-31 at 07:28 -0500, Timur Tabi wrote: > On 10/31/17 4:08 AM, Andy Shevchenko wrote: > > Can you preserve the style and indentation of the commit? > > Does checkpatch warn you about style? (It's apparently not a net > > subsystem) > > I ran checkpatch on it and it didn't complain. Hmm... Okay. > Also, I don't think that when reverting a patch, I am also supposed > to > to fix cosmetic changes of the code that existed before the original > patch. Point taken. Up to Linus how to proceed, it's indeed cosmetic non-code change. -- Andy Shevchenko Intel Finland Oy