From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Timur Tabi <timur@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
thierry.reding@gmail.com, Stephen Boyd <sboyd@codeaurora.org>,
david.brown@linaro.org, andy.gross@linaro.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 2/4] gpiolib: add bitmask for valid GPIO lines
Date: Tue, 31 Oct 2017 21:05:57 +0200 [thread overview]
Message-ID: <1509476757.10233.143.camel@linux.intel.com> (raw)
In-Reply-To: <02208047-38c8-f97b-5c53-6cced7bdecc6@codeaurora.org>
On Tue, 2017-10-31 at 13:54 -0500, Timur Tabi wrote:
> On 10/31/2017 04:12 AM, Andy Shevchenko wrote:
> > Instead of mangling this function wouldn't be better to introduce a
> > separate one for line and perhaps a third one which calls them both?
>
> The diff is convoluted, but the end result is clean:
> Is this acceptable?
I also put in the comment the following:
--- 8< --- 8< --- 8< ---
...for my opinion it will drastically increase readability and reduce
diff as well (better for review).
--- 8< --- 8< --- 8< ---
The decision is up to Linus. I simple shared my opinion.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-10-31 19:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 20:49 [PATCH 0/4] [v6] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-10-30 20:49 ` [PATCH 1/4] Revert "gpio: set up initial state from .get_direction()" Timur Tabi
2017-10-31 9:08 ` Andy Shevchenko
2017-10-31 12:28 ` Timur Tabi
2017-10-31 12:33 ` Fabio Estevam
2017-10-31 12:36 ` Timur Tabi
2017-10-31 12:34 ` Andy Shevchenko
2017-10-30 20:50 ` [PATCH 2/4] gpiolib: add bitmask for valid GPIO lines Timur Tabi
2017-10-31 9:12 ` Andy Shevchenko
2017-10-31 18:54 ` Timur Tabi
2017-10-31 19:05 ` Andy Shevchenko [this message]
2017-10-30 20:50 ` [PATCH 3/4] [v6] pinctrl: qcom: disable GPIO groups with no pins Timur Tabi
2017-10-30 20:50 ` [PATCH 4/4] [v3] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002 Timur Tabi
-- strict thread matches above, loose matches on Subject: below --
2017-11-07 23:07 [PATCH 0/4] [v7] pinctrl: qcom: add support for sparse GPIOs Timur Tabi
2017-11-07 23:07 ` [PATCH 2/4] gpiolib: add bitmask for valid GPIO lines Timur Tabi
2017-12-01 11:38 ` Archit Taneja
2017-12-01 17:16 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509476757.10233.143.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sboyd@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).