From: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
To: "rdunlap@infradead.org" <rdunlap@infradead.org>,
"Eugeniy.Paltsev@synopsys.com" <Eugeniy.Paltsev@synopsys.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Cc: "Vineet.Gupta1@synopsys.com" <Vineet.Gupta1@synopsys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Alexey.Brodkin@synopsys.com" <Alexey.Brodkin@synopsys.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>
Subject: Re: [PATCH 1/2] GPIO: add single-register gpio via creg driver
Date: Tue, 28 Aug 2018 11:04:38 +0000 [thread overview]
Message-ID: <1535454277.24765.1.camel@synopsys.com> (raw)
In-Reply-To: <c5f75b43-6ef3-31e2-0366-b6c8623d3f5d@infradead.org>
Hi Randy,
thanks for comments, will be fixed in patch V2.
On Thu, 2018-08-23 at 08:08 -0700, Randy Dunlap wrote:
> On 08/23/2018 08:00 AM, Eugeniy Paltsev wrote:
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> > index 71c0ab46f216..0f9cc1582cab 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -430,6 +430,15 @@ config GPIO_REG
> > A 32-bit single register GPIO fixed in/out implementation. This
> > can be used to represent any register as a set of GPIO signals.
> >
> > +config GPIO_SNPS_CREG
> > + bool "GPIO via CREG (Control REGisers) driver"
>
> REGisters)
>
> > + select OF_GPIO
> > + help
> > + This driver supports GPIOs via CREG on various Synopsys SoCs.
> > + This is is single-register MMIO gpio driver for complex cases
>
> This is a MMIO GPIO
>
> > + where only several fields in register belong to GPIO and
>
> in a register
>
> > + each GPIO owns field with different length and on/off values.
>
> maybe:
> fields with different lengths
>
> > +
> > config GPIO_SPEAR_SPICS
> > bool "ST SPEAr13xx SPI Chip Select as GPIO support"
> > depends on PLAT_SPEAR
>
>
--
Eugeniy Paltsev
next prev parent reply other threads:[~2018-08-28 11:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 15:00 [PATCH 0/2] GPIO: add single-register gpio via creg driver Eugeniy Paltsev
2018-08-23 15:00 ` [PATCH 1/2] " Eugeniy Paltsev
2018-08-23 15:08 ` Randy Dunlap
2018-08-28 11:04 ` Eugeniy Paltsev [this message]
2018-08-23 15:00 ` [PATCH 2/2] dt-bindings: Document the Synopsys GPIO via CREG bindings Eugeniy Paltsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535454277.24765.1.camel@synopsys.com \
--to=eugeniy.paltsev@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).