* [PATCH -next] pinctrl: mediatek: make symbol 'mtk_drive' static
@ 2018-09-20 6:21 Wei Yongjun
2018-09-21 2:00 ` Sean Wang
2018-09-21 16:03 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2018-09-20 6:21 UTC (permalink / raw)
To: Linus Walleij, Matthias Brugger, Sean Wang, Ryder.Lee,
Zhiyong Tao
Cc: linux-gpio, kernel-janitors, linux-mediatek, Wei Yongjun,
linux-arm-kernel
Fixes the following sparse warning:
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:37:29: warning:
symbol 'mtk_drive' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index 167ebf4..4a9e0d4 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -34,7 +34,7 @@ struct mtk_drive_desc {
};
/* The groups of drive strength */
-const struct mtk_drive_desc mtk_drive[] = {
+static const struct mtk_drive_desc mtk_drive[] = {
[DRV_GRP0] = { 4, 16, 4, 1 },
[DRV_GRP1] = { 4, 16, 4, 2 },
[DRV_GRP2] = { 2, 8, 2, 1 },
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] pinctrl: mediatek: make symbol 'mtk_drive' static
2018-09-20 6:21 [PATCH -next] pinctrl: mediatek: make symbol 'mtk_drive' static Wei Yongjun
@ 2018-09-21 2:00 ` Sean Wang
2018-09-21 16:03 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Sean Wang @ 2018-09-21 2:00 UTC (permalink / raw)
To: Wei Yongjun
Cc: Ryder.Lee, Zhiyong Tao, Linus Walleij, kernel-janitors,
linux-gpio, linux-mediatek, Matthias Brugger, linux-arm-kernel
On Thu, 2018-09-20 at 06:21 +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:37:29: warning:
> symbol 'mtk_drive' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Sean Wang <sean.wang@mediatek.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index 167ebf4..4a9e0d4 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -34,7 +34,7 @@ struct mtk_drive_desc {
> };
>
> /* The groups of drive strength */
> -const struct mtk_drive_desc mtk_drive[] = {
> +static const struct mtk_drive_desc mtk_drive[] = {
> [DRV_GRP0] = { 4, 16, 4, 1 },
> [DRV_GRP1] = { 4, 16, 4, 2 },
> [DRV_GRP2] = { 2, 8, 2, 1 },
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] pinctrl: mediatek: make symbol 'mtk_drive' static
2018-09-20 6:21 [PATCH -next] pinctrl: mediatek: make symbol 'mtk_drive' static Wei Yongjun
2018-09-21 2:00 ` Sean Wang
@ 2018-09-21 16:03 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-09-21 16:03 UTC (permalink / raw)
To: Wei Yongjun
Cc: Ryder Lee, Zhiyong Tao, Sean Wang, kernel-janitors,
open list:GPIO SUBSYSTEM, moderated list:ARM/Mediatek SoC support,
Matthias Brugger, Linux ARM
On Wed, Sep 19, 2018 at 11:12 PM Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Fixes the following sparse warning:
>
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:37:29: warning:
> symbol 'mtk_drive' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Patch applied with Sean's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-21 16:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-20 6:21 [PATCH -next] pinctrl: mediatek: make symbol 'mtk_drive' static Wei Yongjun
2018-09-21 2:00 ` Sean Wang
2018-09-21 16:03 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).