From: Sean Wang <sean.wang@mediatek.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: "Ryder.Lee" <ryder.lee@mediatek.com>,
Zhiyong Tao <zhiyong.tao@mediatek.com>,
Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] pinctrl: mediatek: make symbol 'mtk_drive' static
Date: Fri, 21 Sep 2018 10:00:42 +0800 [thread overview]
Message-ID: <1537495242.9654.1.camel@mtkswgap22> (raw)
In-Reply-To: <1537424502-23554-1-git-send-email-weiyongjun1@huawei.com>
On Thu, 2018-09-20 at 06:21 +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:37:29: warning:
> symbol 'mtk_drive' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Sean Wang <sean.wang@mediatek.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index 167ebf4..4a9e0d4 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -34,7 +34,7 @@ struct mtk_drive_desc {
> };
>
> /* The groups of drive strength */
> -const struct mtk_drive_desc mtk_drive[] = {
> +static const struct mtk_drive_desc mtk_drive[] = {
> [DRV_GRP0] = { 4, 16, 4, 1 },
> [DRV_GRP1] = { 4, 16, 4, 2 },
> [DRV_GRP2] = { 2, 8, 2, 1 },
>
next prev parent reply other threads:[~2018-09-21 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 6:21 [PATCH -next] pinctrl: mediatek: make symbol 'mtk_drive' static Wei Yongjun
2018-09-21 2:00 ` Sean Wang [this message]
2018-09-21 16:03 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537495242.9654.1.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ryder.lee@mediatek.com \
--cc=weiyongjun1@huawei.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).