From: "Enrico Weigelt, metux IT consult" <info@metux.net>
To: linux-kernel@vger.kernel.org
Cc: platform-driver-x86@vger.kernel.org, andy@infradead.org,
dvhart@infradead.org, bgolaszewski@baylibre.com,
linus.walleij@linaro.org, linux-gpio@vger.kernel.org
Subject: APUv2/v3 board support V2
Date: Wed, 13 Feb 2019 21:57:26 +0100 [thread overview]
Message-ID: <1550091448-28578-1-git-send-email-info@metux.net> (raw)
Hi folks,
this is version 2 of my APUv2/APUv3 series. Heavily reworked,
hope I've now addressed all issues of the last one.
Major changes are:
* using gpiod_lookup_table instead of hardcoded gpio numbers
* moved the PCHs gpio register definitions to the gpio drivers'
header (but keeping the actual assignments in the board driver,
as they're board speficic)
* moved IO resource definition from board to gpio driver
(the FCHs mmio base address could be changed, but nobody
seems to ever do it)
* added gpio line names
* moved the gpio driver's pdata definitions to::
include/linux/platform_data/gpio/gpio-amd-fch.h
* reduced some code redundancies and various cleanups
Possibly debatable:
* does is the assigned key code fit well ? (KEY_SETUP seemed the
best candidate to me, but I'm open to suggestions)
* should the pch gpio become a sub-device of some toplevel PCH
device ? (which then could also maintain the base address, etc)
Note: the keyboard device needs separate patch for gpiod_lookup_table
support in gpio-keys-polled driver. I'll sent it separately.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
next reply other threads:[~2019-02-13 20:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 20:57 Enrico Weigelt, metux IT consult [this message]
2019-02-13 20:57 ` [PATCH 1/2] gpio: AMD G-Series PCH gpio driver Enrico Weigelt, metux IT consult
2019-02-14 2:08 ` Andy Shevchenko
2019-02-13 20:57 ` [PATCH 2/2] x86: pcengines apuv2 gpio/leds/keys platform driver Enrico Weigelt, metux IT consult
2019-02-14 2:13 ` Andy Shevchenko
2019-02-14 2:17 ` APUv2/v3 board support V2 Andy Shevchenko
2019-02-14 11:37 ` Enrico Weigelt, metux IT consult
2019-02-14 12:33 ` Andy Shevchenko
2019-02-14 15:04 ` Enrico Weigelt, metux IT consult
2019-02-14 22:04 ` APUv2/v3 board support V3 Enrico Weigelt, metux IT consult
2019-02-14 22:04 ` [PATCH v3 1/2] gpio: AMD G-Series PCH gpio driver Enrico Weigelt, metux IT consult
2019-02-20 9:45 ` Linus Walleij
2019-02-14 22:04 ` [PATCH v3 2/2] x86: pcengines apuv2 gpio/leds/keys platform driver Enrico Weigelt, metux IT consult
2019-02-22 16:29 ` Linus Walleij
2019-02-15 18:16 ` APUv2/v3 board support V3 Andy Shevchenko
2019-02-20 9:58 ` Linus Walleij
2019-02-22 9:54 ` APUv2/v3 board support v4 Enrico Weigelt, metux IT consult
2019-02-22 9:54 ` [PATCH v4 1/2] gpio: AMD G-Series PCH gpio driver Enrico Weigelt, metux IT consult
2019-02-22 16:27 ` Linus Walleij
2019-02-22 9:54 ` [PATCH v4 2/2] x86: pcengines apuv2 gpio/leds/keys platform driver Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550091448-28578-1-git-send-email-info@metux.net \
--to=info@metux.net \
--cc=andy@infradead.org \
--cc=bgolaszewski@baylibre.com \
--cc=dvhart@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).