* [PATCH] drivers: x86: pcengines-apuv2: fix dependencies
@ 2019-03-05 0:24 Enrico Weigelt, metux IT consult
2019-03-05 0:34 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-03-05 0:24 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-gpio, linus.walleij, andy.shevchenko, arnd, rdunlap
pcengines-apuv2 board driver needs to explicitly select LEDS_CLASS,
INPUT, INPUT_KEYBOARD, so these are automatically defined correctly
(eg. LEDS_CLASS=y if PCENGINES_APU2=y)
Cc: linux-gpio@vger.kernel.org
Cc: linus.walleij@linaro.org
Cc: andy.shevchenko@gmail.com
Cc: arnd@arndb.de
Cc: rdunlap@infradead.org
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: arnd@arndb.de
Reported-by: rdunlap@infradead.org
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/platform/x86/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 851ea92..7d53380 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1307,7 +1307,10 @@ config PCENGINES_APU2
tristate "PC Engines APUv2/3 front button and LEDs driver"
select GPIO_AMD_FCH
select KEYBOARD_GPIO_POLLED
+ select LEDS_CLASS
select LEDS_GPIO
+ select INPUT
+ select INPUT_KEYBOARD
help
This driver provides support for the front button and LEDs on
PC Engines APUv2/APUv3 board.
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: x86: pcengines-apuv2: fix dependencies
2019-03-05 0:24 [PATCH] drivers: x86: pcengines-apuv2: fix dependencies Enrico Weigelt, metux IT consult
@ 2019-03-05 0:34 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2019-03-05 0:34 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult, linux-kernel
Cc: linux-gpio, linus.walleij, andy.shevchenko, arnd
On 3/4/19 4:24 PM, Enrico Weigelt, metux IT consult wrote:
> pcengines-apuv2 board driver needs to explicitly select LEDS_CLASS,
> INPUT, INPUT_KEYBOARD, so these are automatically defined correctly
> (eg. LEDS_CLASS=y if PCENGINES_APU2=y)
>
> Cc: linux-gpio@vger.kernel.org
> Cc: linus.walleij@linaro.org
> Cc: andy.shevchenko@gmail.com
> Cc: arnd@arndb.de
> Cc: rdunlap@infradead.org
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: arnd@arndb.de
> Reported-by: rdunlap@infradead.org
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/platform/x86/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 851ea92..7d53380 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1307,7 +1307,10 @@ config PCENGINES_APU2
> tristate "PC Engines APUv2/3 front button and LEDs driver"
> select GPIO_AMD_FCH
> select KEYBOARD_GPIO_POLLED
> + select LEDS_CLASS
> select LEDS_GPIO
> + select INPUT
Nak. We don't select entire subsystems. You should do:
depends on INPUT
select INPUT_KEYBOARD
> + select INPUT_KEYBOARD
> help
> This driver provides support for the front button and LEDs on
> PC Engines APUv2/APUv3 board.
>
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-05 0:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-05 0:24 [PATCH] drivers: x86: pcengines-apuv2: fix dependencies Enrico Weigelt, metux IT consult
2019-03-05 0:34 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).