From: dillon.minfei@gmail.com
To: linus.walleij@linaro.org, lee.jones@linaro.org,
bgolaszewski@baylibre.com
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
dillon min <dillon.minfei@gmail.com>
Subject: [PATCH: V2 1/2] gpio: tc35894: fix up tc35894 interrupt configuration
Date: Thu, 3 Sep 2020 15:30:21 +0800 [thread overview]
Message-ID: <1599118222-18990-2-git-send-email-dillon.minfei@gmail.com> (raw)
In-Reply-To: <1599118222-18990-1-git-send-email-dillon.minfei@gmail.com>
From: dillon min <dillon.minfei@gmail.com>
The offset of regmap is incorrect, j * 8 is move to the
wrong register.
for example:
asume i = 0, j = 1. we want to set KPY5 as interrupt
falling edge mode, regmap[0][1] should be TC3589x_GPIOIBE1 0xcd
but, regmap[i] + j * 8 = TC3589x_GPIOIBE0 + 8 ,point to 0xd4,
this is TC3589x_GPIOIE2 not TC3589x_GPIOIBE1.
Fixes: d88b25be3584 ("gpio: Add TC35892 GPIO driver")
Signed-off-by: dillon min <dillon.minfei@gmail.com>
---
Hi, Bartosz
Just change Fixes tag.
Thanks.
Dillon
drivers/gpio/gpio-tc3589x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
index 58b0da9eb76f..ea3f68a28fea 100644
--- a/drivers/gpio/gpio-tc3589x.c
+++ b/drivers/gpio/gpio-tc3589x.c
@@ -212,7 +212,7 @@ static void tc3589x_gpio_irq_sync_unlock(struct irq_data *d)
continue;
tc3589x_gpio->oldregs[i][j] = new;
- tc3589x_reg_write(tc3589x, regmap[i] + j * 8, new);
+ tc3589x_reg_write(tc3589x, regmap[i] + j, new);
}
}
--
2.7.4
next prev parent reply other threads:[~2020-09-03 7:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 7:30 [PATCH: V2 0/2] Fix TC35894 gpio interrupt bug dillon.minfei
2020-09-03 7:30 ` dillon.minfei [this message]
2020-09-09 9:34 ` [PATCH: V2 1/2] gpio: tc35894: fix up tc35894 interrupt configuration Bartosz Golaszewski
2020-09-03 7:30 ` [PATCH: V2 2/2] gpio: tc35894: Disable Direct KBD interrupts to enable gpio irq dillon.minfei
2020-09-08 14:04 ` Lee Jones
2020-09-09 9:33 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1599118222-18990-2-git-send-email-dillon.minfei@gmail.com \
--to=dillon.minfei@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).