From: Michael Walle <michael@walle.cc>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jiawen Wu <jiawenwu@trustnetic.com>,
linus.walleij@linaro.org, brgl@bgdev.pl,
shreeya.patel@collabora.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] gpiolib: Fix GPIO chip IRQ initialization restriction
Date: Thu, 15 Jun 2023 11:26:17 +0200 [thread overview]
Message-ID: <15e2fc098a1e63317368f4812290ca35@walle.cc> (raw)
In-Reply-To: <CAHp75Vdbq3uHOyrfT-KFYRSj6v+s9GgOQjQ9a8mGn-4HSCpB9Q@mail.gmail.com>
Am 2023-06-07 16:12, schrieb Andy Shevchenko:
> +Cc: Michael
>
> On Wed, Jun 7, 2023 at 11:20 AM Jiawen Wu <jiawenwu@trustnetic.com>
> wrote:
>>
>> In case of gpio-regmap, IRQ chip is added by regmap-irq and associated
>> with
>> GPIO chip by gpiochip_irqchip_add_domain(). The initialization flag
>> was not
>> added in gpiochip_irqchip_add_domain(), causing gpiochip_to_irq() to
>> return
>> -EPROBE_DEFER.
>
> Makes sense to me.
> FWIW,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> But it would be nice to hear from Michael about this.
Thanks for bringing this to my attention. In fact, currently
my sl28cpld is broken due to this. So:
Reviewed-by: Michael Walle <michael@walle.cc>
Tested-by: Michael Walle <michael@walle.cc> # on kontron-sl28
>> Fixes: 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members
>> before initialization")
>> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
-michael
next prev parent reply other threads:[~2023-06-15 9:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 8:18 [PATCH v2] gpiolib: Fix GPIO chip IRQ initialization restriction Jiawen Wu
2023-06-07 14:12 ` Andy Shevchenko
2023-06-15 9:26 ` Michael Walle [this message]
2023-06-15 9:34 ` Shreeya Patel
2023-06-15 9:52 ` Jiawen Wu
2023-06-15 10:45 ` Michael Walle
2023-06-15 13:55 ` Andy Shevchenko
2023-06-16 2:11 ` Jiawen Wu
2023-06-16 2:20 ` Jiawen Wu
2023-06-09 7:37 ` Linus Walleij
2023-06-13 12:41 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15e2fc098a1e63317368f4812290ca35@walle.cc \
--to=michael@walle.cc \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=jiawenwu@trustnetic.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).