From: zhiyong tao <zhiyong.tao@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <biao.huang@mediatek.com>,
<linus.walleij@linaro.org>, <hongzhou.yang@mediatek.com>,
<srv_heupstream@mediatek.com>, <jg_poxu@mediatek.com>,
<devicetree@vger.kernel.org>, <mark.rutland@arm.com>,
<matthias.bgg@gmail.com>, <sean.wang@mediatek.com>,
<linux-gpio@vger.kernel.org>, <erin.lo@mediatek.com>,
<hui.liu@mediatek.com>, <sean.wang@kernel.org>,
<sj.huang@mediatek.com>, <eddie.huang@mediatek.com>,
<linux-mediatek@lists.infradead.org>, <seiya.wang@mediatek.com>
Subject: Re: [PATCH Resend v0 2/6] dt-bindings: pinctrl: mt8195: add binding document
Date: Wed, 31 Mar 2021 08:32:23 +0800 [thread overview]
Message-ID: <1617150743.10316.18.camel@mhfsdcap03> (raw)
In-Reply-To: <20210330133913.GA212608@robh.at.kernel.org>
On Tue, 2021-03-30 at 08:39 -0500, Rob Herring wrote:
> On Tue, Mar 30, 2021 at 05:05:28PM +0800, zhiyong tao wrote:
> > On Mon, 2021-03-29 at 14:21 -0500, Rob Herring wrote:
> > > On Mon, 29 Mar 2021 19:30:59 +0800, Zhiyong Tao wrote:
> > > > The commit adds mt8195 compatible node in binding document.
> > > >
> > > > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> > > > ---
> > > > .../bindings/pinctrl/pinctrl-mt8195.yaml | 152 ++++++++++++++++++
> > > > 1 file changed, 152 insertions(+)
> > > > create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> > > >
> > >
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > >
> > > yamllint warnings/errors:
> > >
> > > dtschema/dtc warnings/errors:
> > > Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.example.dts:19:18: fatal error: dt-bindings/pinctrl/mt8195-pinfunc.h: No such file or directory
> > > 19 | #include <dt-bindings/pinctrl/mt8195-pinfunc.h>
> > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > compilation terminated.
> > > make[1]: *** [scripts/Makefile.lib:349: Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.example.dt.yaml] Error 1
> > > make[1]: *** Waiting for unfinished jobs....
> > > make: *** [Makefile:1380: dt_binding_check] Error 2
> > >
> > > See https://patchwork.ozlabs.org/patch/1459558
> > >
> > > This check can fail if there are any dependencies. The base for a patch
> > > series is generally the most recent rc1.
> > >
> > > If you already ran 'make dt_binding_check' and didn't see the above
> > > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > > date:
> > >
> > > pip3 install dtschema --upgrade
> > >
> > > Please check and re-submit.
> > >
> >
> > ==> I set the patch file "mt8195-pinfunc.h" patch in "4/6". so we should
> > add the file "mt8195-pinfunc.h" in this patch ? or we should put it
> > before this patch(2/6)?
>
> It is part of the binding, so it belongs in this patch.
>
> Rob
==> Thanks for your suggestion. We will add it in this patch in next
version.
next prev parent reply other threads:[~2021-03-31 0:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 11:30 [PATCH Resend v0 0/6] Mediatek pinctrl patch on mt8195 Zhiyong Tao
2021-03-29 11:30 ` [PATCH Resend v0 1/6] dt-bindings: pinctrl: mt8195: add pinctrl file Zhiyong Tao
2021-03-29 11:30 ` [PATCH Resend v0 2/6] dt-bindings: pinctrl: mt8195: add binding document Zhiyong Tao
2021-03-29 19:21 ` Rob Herring
2021-03-30 9:05 ` zhiyong tao
2021-03-30 13:39 ` Rob Herring
2021-03-31 0:32 ` zhiyong tao [this message]
2021-03-29 11:31 ` [PATCH Resend v0 3/6] arm64: dts: mt8195: add pinctrl device node Zhiyong Tao
2021-03-29 11:31 ` [PATCH Resend v0 4/6] pinctrl: add pinctrl driver on mt8195 Zhiyong Tao
2021-03-29 11:31 ` [PATCH Resend v0 5/6] pinctrl: add drive for I2C related pins on MT8195 Zhiyong Tao
2021-03-29 11:31 ` [PATCH Resend v0 6/6] pinctrl: add rsel setting " Zhiyong Tao
2021-03-29 11:35 ` [PATCH Resend v0 0/6] Mediatek pinctrl patch on mt8195 Andy Shevchenko
2021-03-29 11:49 ` zhiyong tao
2021-03-29 11:51 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617150743.10316.18.camel@mhfsdcap03 \
--to=zhiyong.tao@mediatek.com \
--cc=biao.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=erin.lo@mediatek.com \
--cc=hongzhou.yang@mediatek.com \
--cc=hui.liu@mediatek.com \
--cc=jg_poxu@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=seiya.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).