From: Rob Herring <robh@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
Jon Hunter <jonathanh@nvidia.com>,
devicetree@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] dt-bindings: pinctrl: tegra: Convert to json-schema
Date: Fri, 17 Dec 2021 16:25:06 -0600 [thread overview]
Message-ID: <1639779906.600898.3686970.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211217165342.2572021-1-thierry.reding@gmail.com>
On Fri, 17 Dec 2021 17:53:42 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Convert the NVIDIA Tegra pinmux controller bindings from the free-form
> text format to json-schema.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../pinctrl/nvidia,tegra114-pinmux.txt | 131 --------
> .../pinctrl/nvidia,tegra114-pinmux.yaml | 264 ++++++++++++++++
> .../pinctrl/nvidia,tegra124-pinmux.txt | 153 ----------
> .../pinctrl/nvidia,tegra124-pinmux.yaml | 287 ++++++++++++++++++
> .../pinctrl/nvidia,tegra194-pinmux.txt | 107 -------
> .../pinctrl/nvidia,tegra194-pinmux.yaml | 175 +++++++++++
> .../pinctrl/nvidia,tegra20-pinmux.txt | 143 ---------
> .../pinctrl/nvidia,tegra20-pinmux.yaml | 203 +++++++++++++
> .../pinctrl/nvidia,tegra210-pinmux.txt | 166 ----------
> .../pinctrl/nvidia,tegra210-pinmux.yaml | 232 ++++++++++++++
> .../pinctrl/nvidia,tegra30-pinmux.txt | 144 ---------
> .../pinctrl/nvidia,tegra30-pinmux.yaml | 268 ++++++++++++++++
> 12 files changed, 1429 insertions(+), 844 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.example.dt.yaml:0:0: /example-0/mmc@700b0600: failed to match any schema with compatible: ['nvidia,tegra124-sdhci']
Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.example.dt.yaml:0:0: /example-0/mmc@c8000600: failed to match any schema with compatible: ['nvidia,tegra20-sdhci']
doc reference errors (make refcheckdocs):
Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt: Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.txt
See https://patchwork.ozlabs.org/patch/1570184
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-12-17 22:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 16:53 [PATCH] dt-bindings: pinctrl: tegra: Convert to json-schema Thierry Reding
2021-12-17 22:25 ` Rob Herring [this message]
2021-12-21 13:51 ` Rob Herring
2021-12-21 14:10 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1639779906.600898.3686970.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).