From: Rob Herring <robh@kernel.org>
To: Guodong Liu <guodong.liu@mediatek.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Sean Wang <sean.wang@mediatek.com>,
linux-mediatek@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-gpio@vger.kernel.org, Sean Wang <sean.wang@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: mt8186: add pinctrl file and binding document
Date: Thu, 10 Feb 2022 08:47:52 -0600 [thread overview]
Message-ID: <1644504472.320340.2624780.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220210062122.23974-2-guodong.liu@mediatek.com>
On Thu, 10 Feb 2022 14:21:20 +0800, Guodong Liu wrote:
> 1. This patch adds pinctrl file for mt8186.
> 2. This patch adds mt8186 compatible node in binding document.
>
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
> ---
> .../bindings/pinctrl/pinctrl-mt8186.yaml | 313 +++++
> include/dt-bindings/pinctrl/mt8186-pinfunc.h | 1174 +++++++++++++++++
> 2 files changed, 1487 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
> create mode 100644 include/dt-bindings/pinctrl/mt8186-pinfunc.h
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml: properties:reg-names: {'description': 'Gpio base register names.\n', 'items': [{'const': 'iocfg0'}, {'const': 'iocfg_bm'}, {'const': 'iocfg_bl'}, {'const': 'iocfg_br'}, {'const': 'iocfg_lm'}, {'const': 'iocfg_rb'}, {'const': 'iocfg_tl'}, {'const': 'eint'}], 'maxItems': 8} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml: ignoring, error in schema: properties: reg-names
Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.example.dt.yaml:0:0: /example-0/pinctrl@10005000: failed to match any schema with compatible: ['mediatek,mt8186-pinctrl']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1590838
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-02-10 14:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 6:21 [PATCH v3 0/2] pinctrl: mediatek: Support pinctrl driver on mt8186 Guodong Liu
2022-02-10 6:21 ` [PATCH v3 1/3] dt-bindings: pinctrl: mt8186: add pinctrl file and binding document Guodong Liu
2022-02-10 14:47 ` Rob Herring [this message]
2022-02-14 3:03 ` Guodong Liu
2022-02-11 0:10 ` Linus Walleij
2022-02-11 12:28 ` Rob Herring
2022-02-14 3:04 ` Guodong Liu
2022-02-10 6:21 ` [PATCH v3 2/3] pinctrl: add pinctrl driver on mt8186 Guodong Liu
2022-02-10 8:57 ` AngeloGioacchino Del Regno
2022-02-14 3:02 ` Guodong Liu
2022-02-10 6:21 ` [PATCH v3 3/3] pinctrl: canonical rsel resistance selection property Guodong Liu
2022-02-10 8:50 ` AngeloGioacchino Del Regno
2022-02-14 3:03 ` Guodong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1644504472.320340.2624780.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=guodong.liu@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).