[PATCH] pinctrl: Fix an error in pin-function table of SP7021

[PATCH] pinctrl: Fix an error in pin-function table of SP7021

[Wells Lu]

The first valid item of pin-function table should
start from the third item. The first two items,
due to historical and compatible reasons, should
be dummy items.

The two dummy items were removed accidentally in
initial submission. This fix adds them back.

Signed-off-by: Wells Lu <wellslutw@gmail.com>
---
 drivers/pinctrl/sunplus/sppctl_sp7021.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/pinctrl/sunplus/sppctl_sp7021.c b/drivers/pinctrl/sunplus/sppctl_sp7021.c
index 9748345..cd65776 100644
--- a/drivers/pinctrl/sunplus/sppctl_sp7021.c
+++ b/drivers/pinctrl/sunplus/sppctl_sp7021.c
@@ -419,7 +419,15 @@ static const struct sppctl_grp sp7021grps_prbp[] = {
 	EGRP("PROBE_PORT2", 2, pins_prp2),
 };
 
+/*
+ * Due to compatible reason, the first valid item should start at the third
+ * position of the array. Please keep the first two items of the table
+ * no use (dummy).
+ */
 const struct sppctl_func sppctl_list_funcs[] = {
+	FNCN("", pinmux_type_fpmx, 0x00, 0, 0),
+	FNCN("", pinmux_type_fpmx, 0x00, 0, 0),
+
 	FNCN("L2SW_CLK_OUT",        pinmux_type_fpmx, 0x00, 0, 7),
 	FNCN("L2SW_MAC_SMI_MDC",    pinmux_type_fpmx, 0x00, 8, 7),
 	FNCN("L2SW_LED_FLASH0",     pinmux_type_fpmx, 0x01, 0, 7),
-- 
2.7.4

Re: [PATCH] pinctrl: Fix an error in pin-function table of SP7021

[Linus Walleij]

On Fri, Apr 15, 2022 at 11:41 AM Wells Lu <wellslutw@gmail.com> wrote:

> The first valid item of pin-function table should
> start from the third item. The first two items,
> due to historical and compatible reasons, should
> be dummy items.
>
> The two dummy items were removed accidentally in
> initial submission. This fix adds them back.
>
> Signed-off-by: Wells Lu <wellslutw@gmail.com>

Patch applied for fixes!

Yours,
Linus Walleij