[PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples

[PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples

[AngeloGioacchino Del Regno]

The property mediatek,drive-strength-adv was deprecated: change the
example for i2c0-pins to use drive-strength-microamp.

Fixes: b6d9af2c6b69 ("dt-bindings: pinctrl: mt8195: Add and use drive-strength-microamp")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
index 85e96a5e1708..66fe17e9e4d3 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
@@ -281,7 +281,7 @@ examples:
           pinmux = <PINMUX_GPIO8__FUNC_SDA0>,
                    <PINMUX_GPIO9__FUNC_SCL0>;
           bias-disable;
-          mediatek,drive-strength-adv = <7>;
+          drive-strength-microamp = <1000>;
         };
       };
     };
-- 
2.35.1

Re: [PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples

[Rob Herring]

On Fri, 15 Jul 2022 12:30:29 +0200, AngeloGioacchino Del Regno wrote:
> The property mediatek,drive-strength-adv was deprecated: change the
> example for i2c0-pins to use drive-strength-microamp.
> 
> Fixes: b6d9af2c6b69 ("dt-bindings: pinctrl: mt8195: Add and use drive-strength-microamp")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.example.dtb: pinctrl@10005000: i2c0-pins:pins: 'drive-strength-microamp' does not match any of the regexes: 'pinctrl-[0-9]+'
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

Re: [PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples

[Rob Herring]

On Fri, Jul 15, 2022 at 07:42:55AM -0600, Rob Herring wrote:
> On Fri, 15 Jul 2022 12:30:29 +0200, AngeloGioacchino Del Regno wrote:
> > The property mediatek,drive-strength-adv was deprecated: change the
> > example for i2c0-pins to use drive-strength-microamp.
> > 
> > Fixes: b6d9af2c6b69 ("dt-bindings: pinctrl: mt8195: Add and use drive-strength-microamp")
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> >  Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.example.dtb: pinctrl@10005000: i2c0-pins:pins: 'drive-strength-microamp' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml

Seems to be a false positive since commit b6d9af2c6b69 was not present 
in the test.

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples

[Linus Walleij]

On Fri, Jul 15, 2022 at 12:30 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:

> The property mediatek,drive-strength-adv was deprecated: change the
> example for i2c0-pins to use drive-strength-microamp.
>
> Fixes: b6d9af2c6b69 ("dt-bindings: pinctrl: mt8195: Add and use drive-strength-microamp")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

After finding this in my Inbox, drop my own uglyfix and apply this instead.

Yours,
Linus Walleij

Re: [PATCH] dt-bindings: pinctrl: mt8195: Use drive-strength-microamp in examples

[AngeloGioacchino Del Regno]

Il 18/07/22 15:35, Linus Walleij ha scritto:
> On Fri, Jul 15, 2022 at 12:30 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
> 
>> The property mediatek,drive-strength-adv was deprecated: change the
>> example for i2c0-pins to use drive-strength-microamp.
>>
>> Fixes: b6d9af2c6b69 ("dt-bindings: pinctrl: mt8195: Add and use drive-strength-microamp")
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
> After finding this in my Inbox, drop my own uglyfix and apply this instead.
> 
> Yours,
> Linus Walleij

Thank you!