From: Rob Herring <robh@kernel.org>
To: Hui Liu <hui.liu@mediatek.com>
Cc: linux-gpio@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
jianguo.zhang@mediatek.com, sean.wang@mediatek.com,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
zhiyong.tao@mediatek.com, linux-arm-kernel@lists.infradead.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
matthias.bgg@gmail.com
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: add support for MediaTek mt8188
Date: Wed, 27 Jul 2022 07:57:12 -0600 [thread overview]
Message-ID: <1658930232.177263.2552037.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220727102140.6676-2-hui.liu@mediatek.com>
On Wed, 27 Jul 2022 18:21:39 +0800, Hui Liu wrote:
> From: "Hui.Liu" <hui.liu@mediatek.com>
>
> Add pinctrl function header file and binding document for mt8188.
>
> Signed-off-by: Hui.Liu <hui.liu@mediatek.com>
> ---
> .../pinctrl/mediatek,mt8188-pinctrl.yaml | 238 +++
> .../pinctrl/mediatek,mt8188-pinfunc.h | 1280 +++++++++++++++++
> 2 files changed, 1518 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
> create mode 100644 include/dt-bindings/pinctrl/mediatek,mt8188-pinfunc.h
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/pinctrl/mediatek,mt8188-pinctrl.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: spi0-pins:pins-spi:bias-pull-up: More than one condition true in oneOf schema:
{'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [200,
201,
202,
203,
204,
205,
206,
207]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [1000,
1500,
2000,
3000,
4000,
5000,
10000,
75000]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{}]}
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: spi0-pins:pins-spi-mi:bias-pull-down: More than one condition true in oneOf schema:
{'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [200,
201,
202,
203,
204,
205,
206,
207]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [75000, 5000]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{}]}
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: i2c0-pins:pins:bias-pull-down: More than one condition true in oneOf schema:
{'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [200,
201,
202,
203,
204,
205,
206,
207]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [75000, 5000]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{}]}
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: i2c1-pins:pins:bias-pull-up: More than one condition true in oneOf schema:
{'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [200,
201,
202,
203,
204,
205,
206,
207]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{},
{'items': [{'items': [{'enum': [1000,
1500,
2000,
3000,
4000,
5000,
10000,
75000]}],
'maxItems': 1,
'minItems': 1,
'type': 'array'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{}]}
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-07-27 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 10:21 [PATCH v2 0/2] MediaTek pinctrl patch on mt8188 Hui Liu
2022-07-27 10:21 ` [PATCH v2 1/2] dt-bindings: pinctrl: add support for MediaTek mt8188 Hui Liu
2022-07-27 10:30 ` Krzysztof Kozlowski
2022-07-27 13:57 ` Rob Herring [this message]
2022-07-27 10:21 ` [PATCH v2 2/2] pinctrl: mediatek: add mt8188 driver Hui Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1658930232.177263.2552037.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hui.liu@mediatek.com \
--cc=jianguo.zhang@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).