From: Wells Lu <wellslutw@gmail.com>
To: linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: wells.lu@sunplus.com, Wells Lu <wellslutw@gmail.com>
Subject: [PATCH] pinctrl:sunplus: Add check for kmalloc
Date: Tue, 23 May 2023 18:11:28 +0800 [thread overview]
Message-ID: <1684836688-9204-1-git-send-email-wellslutw@gmail.com> (raw)
Fix Smatch static checker warning:
potential null dereference 'configs'. (kmalloc returns null)
Fixes: aa74c44be19c ("pinctrl: Add driver for Sunplus SP7021")
Signed-off-by: Wells Lu <wellslutw@gmail.com>
---
drivers/pinctrl/sunplus/sppctl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/pinctrl/sunplus/sppctl.c b/drivers/pinctrl/sunplus/sppctl.c
index 6bbbab3a6..f2dcc68ee 100644
--- a/drivers/pinctrl/sunplus/sppctl.c
+++ b/drivers/pinctrl/sunplus/sppctl.c
@@ -883,6 +883,8 @@ static int sppctl_dt_node_to_map(struct pinctrl_dev *pctldev, struct device_node
(*map)[i].data.configs.num_configs = 1;
(*map)[i].data.configs.group_or_pin = pin_get_name(pctldev, pin_num);
configs = kmalloc(sizeof(*configs), GFP_KERNEL);
+ if (!configs)
+ return -ENOMEM;
*configs = FIELD_GET(GENMASK(7, 0), dt_pin);
(*map)[i].data.configs.configs = configs;
@@ -896,6 +898,8 @@ static int sppctl_dt_node_to_map(struct pinctrl_dev *pctldev, struct device_node
(*map)[i].data.configs.num_configs = 1;
(*map)[i].data.configs.group_or_pin = pin_get_name(pctldev, pin_num);
configs = kmalloc(sizeof(*configs), GFP_KERNEL);
+ if (!configs)
+ return -ENOMEM;
*configs = SPPCTL_IOP_CONFIGS;
(*map)[i].data.configs.configs = configs;
--
2.25.1
next reply other threads:[~2023-05-23 10:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 10:11 Wells Lu [this message]
2023-05-23 16:42 ` [PATCH] pinctrl:sunplus: Add check for kmalloc andy.shevchenko
2023-05-23 17:39 ` Wells Lu 呂芳騰
2023-05-23 19:37 ` andy.shevchenko
2023-05-23 20:05 ` Christophe JAILLET
2023-05-25 3:22 ` Wells Lu 呂芳騰
2023-05-25 18:37 ` Christophe JAILLET
2023-05-25 19:42 ` Dan Carpenter
2023-05-26 2:04 ` Wells Lu 呂芳騰
2023-05-26 5:19 ` Christophe JAILLET
2023-05-25 19:19 ` Dan Carpenter
2023-05-25 20:00 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1684836688-9204-1-git-send-email-wellslutw@gmail.com \
--to=wellslutw@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).