[PATCH libgpiod] build: bump required GLib version for tests to 2.74

[PATCH libgpiod] build: bump required GLib version for tests to 2.74

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Since commit c116b6f6f118 ("tests: add a test-case checking line-config
memory usage") we're using a symbol - G_TEST_SUBPROCESS_DEFAULT - that's
only available in GLib v2.74 and later. This version is already almost
three years old so should be widely available. Bump the required version
in configure.ac.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 9b6c862..fe96739 100644
--- a/configure.ac
+++ b/configure.ac
@@ -157,8 +157,8 @@ then
 	PKG_CHECK_MODULES([MOUNT], [mount >= 2.33.1])
 
 	# For core library tests
-	PKG_CHECK_MODULES([GLIB], [glib-2.0 >= 2.50])
-	PKG_CHECK_MODULES([GIO], [gio-2.0 >= 2.50])
+	PKG_CHECK_MODULES([GLIB], [glib-2.0 >= 2.74])
+	PKG_CHECK_MODULES([GIO], [gio-2.0 >= 2.74])
 
 	AC_CHECK_FUNC([atexit], [], [FUNC_NOT_FOUND_LIB([atexit])])
 	AC_CHECK_FUNC([asprintf], [], [FUNC_NOT_FOUND_LIB([asprintf])])
-- 
2.48.1

Re: [PATCH libgpiod] build: bump required GLib version for tests to 2.74

[Bartosz Golaszewski]

On Tue, Aug 26, 2025 at 7:41 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Since commit c116b6f6f118 ("tests: add a test-case checking line-config
> memory usage") we're using a symbol - G_TEST_SUBPROCESS_DEFAULT - that's
> only available in GLib v2.74 and later. This version is already almost
> three years old so should be widely available. Bump the required version
> in configure.ac.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Oh and I forgot:

Reported-by: Vincent Fazio <vfazio@xes-inc.com>

> ---
>  configure.ac | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 9b6c862..fe96739 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -157,8 +157,8 @@ then
>         PKG_CHECK_MODULES([MOUNT], [mount >= 2.33.1])
>
>         # For core library tests
> -       PKG_CHECK_MODULES([GLIB], [glib-2.0 >= 2.50])
> -       PKG_CHECK_MODULES([GIO], [gio-2.0 >= 2.50])
> +       PKG_CHECK_MODULES([GLIB], [glib-2.0 >= 2.74])
> +       PKG_CHECK_MODULES([GIO], [gio-2.0 >= 2.74])
>
>         AC_CHECK_FUNC([atexit], [], [FUNC_NOT_FOUND_LIB([atexit])])
>         AC_CHECK_FUNC([asprintf], [], [FUNC_NOT_FOUND_LIB([asprintf])])
> --
> 2.48.1
>

Re: [PATCH libgpiod] build: bump required GLib version for tests to 2.74

[Vincent Fazio]

> 
> Oh and I forgot:
> 
> Reported-by: Vincent Fazio <vfazio@xes-inc.com>

Thanks!

> 
> > ---
> >  configure.ac | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 9b6c862..fe96739 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -157,8 +157,8 @@ then
> >         PKG_CHECK_MODULES([MOUNT], [mount >= 2.33.1])
> >
> >         # For core library tests
> > -       PKG_CHECK_MODULES([GLIB], [glib-2.0 >= 2.50])
> > -       PKG_CHECK_MODULES([GIO], [gio-2.0 >= 2.50])
> > +       PKG_CHECK_MODULES([GLIB], [glib-2.0 >= 2.74])
> > +       PKG_CHECK_MODULES([GIO], [gio-2.0 >= 2.74])

I know there was a lot of noise in the Github issue (my fault), but did you decide that it's not worthwhile to implement Philip's suggestion of GLIB_VERSION_{MAX_ALLOWED, MIN_REQUIRED} to "enforce" the cap?

I didn't have time to try that out via Makefile.am in the respective subfolders.

> >
> >         AC_CHECK_FUNC([atexit], [], [FUNC_NOT_FOUND_LIB([atexit])])
> >         AC_CHECK_FUNC([asprintf], [], [FUNC_NOT_FOUND_LIB([asprintf])])
> > --
> > 2.48.1
> >

Re: [PATCH libgpiod] build: bump required GLib version for tests to 2.74

[Bartosz Golaszewski]

On Tue, Aug 26, 2025 at 7:54 PM Vincent Fazio <vfazio@xes-inc.com> wrote:
>
> >
> > Oh and I forgot:
> >
> > Reported-by: Vincent Fazio <vfazio@xes-inc.com>
>
> Thanks!
>
> >
> > > ---
> > >  configure.ac | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/configure.ac b/configure.ac
> > > index 9b6c862..fe96739 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -157,8 +157,8 @@ then
> > >         PKG_CHECK_MODULES([MOUNT], [mount >= 2.33.1])
> > >
> > >         # For core library tests
> > > -       PKG_CHECK_MODULES([GLIB], [glib-2.0 >= 2.50])
> > > -       PKG_CHECK_MODULES([GIO], [gio-2.0 >= 2.50])
> > > +       PKG_CHECK_MODULES([GLIB], [glib-2.0 >= 2.74])
> > > +       PKG_CHECK_MODULES([GIO], [gio-2.0 >= 2.74])
>
> I know there was a lot of noise in the Github issue (my fault), but did you decide that it's not worthwhile to implement Philip's suggestion of GLIB_VERSION_{MAX_ALLOWED, MIN_REQUIRED} to "enforce" the cap?
>

I don't believe it makes sense for us. Users are already unable to
build with anything less than v2.74 as configure will bail-out.

> I didn't have time to try that out via Makefile.am in the respective subfolders.
>
> > >
> > >         AC_CHECK_FUNC([atexit], [], [FUNC_NOT_FOUND_LIB([atexit])])
> > >         AC_CHECK_FUNC([asprintf], [], [FUNC_NOT_FOUND_LIB([asprintf])])
> > > --
> > > 2.48.1
> > >
>

One more tag I forgot:

Closes: https://github.com/brgl/libgpiod/issues/143

Bart

Re: [PATCH libgpiod] build: bump required GLib version for tests to 2.74

[Vincent Fazio]

> >
> > I know there was a lot of noise in the Github issue (my fault), but did you
> decide that it's not worthwhile to implement Philip's suggestion of
> GLIB_VERSION_{MAX_ALLOWED, MIN_REQUIRED} to "enforce" the cap?
> >
> 
> I don't believe it makes sense for us. Users are already unable to
> build with anything less than v2.74 as configure will bail-out.

OK.

I just will mention that setting GLIB_VERSION_MAX_ALLOWED will throw warnings if features from a newer version are used that may work on the user's build machine but exceed the version called out. I think if that had been set we may have noticed this issue sooner.

Acked-by: Vincent Fazio <vfazio@xes-inc.com>

Re: [PATCH libgpiod] build: bump required GLib version for tests to 2.74

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Tue, 26 Aug 2025 19:41:23 +0200, Bartosz Golaszewski wrote:
> Since commit c116b6f6f118 ("tests: add a test-case checking line-config
> memory usage") we're using a symbol - G_TEST_SUBPROCESS_DEFAULT - that's
> only available in GLib v2.74 and later. This version is already almost
> three years old so should be widely available. Bump the required version
> in configure.ac.
> 
> 
> [...]

Applied, thanks!

[1/1] build: bump required GLib version for tests to 2.74
      https://git.kernel.org/brgl/libgpiod/c/5e744bf56d84947203b191a79c2e505bcf8d9900

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>