From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFC752F12A5; Wed, 5 Nov 2025 09:00:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762333216; cv=none; b=hCbqhp9OrVVpcWxjyUhEO3+E41W0CrpYdtgirvGO0YuxLyKgO01RkM/gCoRXsTBlhUQie81l+9cSAj4e2pbii3rITBp6rDzNPg9kZmt4dBPkrh3rzcKamiLhlSurz64FQW1GOPMxtVXG8jbUZJZegqDwLxAEoz3k6l1qWU8srL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762333216; c=relaxed/simple; bh=rEzwEs+yJAIoQExDfVRQ9vn4jFUd5q2ZMcOlcMimKqs=; h=Date:Content-Type:MIME-Version:From:Cc:To:In-Reply-To:References: Message-Id:Subject; b=Q3FTkJhIFc5aTkUDq+1bTxwvKyzpBJvIvJ+bxpJwlKYJXHlKkRFw6p+89oe/1Ff6XZmnDI2UEPhLwh1xZN1DOfwp+AKYlmWkDLX16tzdl7Y/d45juoKU/lUhDtHMDBi48bxLGwDLqbUfd3yXm4FJJcBCGe8QH+It5F80nG2qi9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qkk/g2HF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qkk/g2HF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46BABC116B1; Wed, 5 Nov 2025 09:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762333215; bh=rEzwEs+yJAIoQExDfVRQ9vn4jFUd5q2ZMcOlcMimKqs=; h=Date:From:Cc:To:In-Reply-To:References:Subject:From; b=qkk/g2HFQsw36jgb+BG6+sHZFJCiPoiZr4OUOZjXtnFUgUL6rNzcUukcJio9Xx9Uq aT0gljuWDVheRc1wULO3Fr2cLJvrqxbeDQ56b/GhcL0pdKtAT/uXdkt+gF+lM0LBas m7e1FRGPEVCWHfL9WQFnUZeS5K7ZaOvFaDBXdFYbGc/Cmn4+tu5b3zqgjlsNi4A2Pq 8TVR9SJJ+gyTn4Lm7ro+cT8z4i8tLaBmu/JTTNVirrp1/lxGEx2sQbCV+SqGoEJihO NtOtQLZmj8E/V0AJ+rZ7q5YYFJAZIqBVPu4843Dl9k1MatNFGjBCJ45S27w+s693E5 Cu4FtSzHzXDzg== Date: Wed, 05 Nov 2025 03:00:14 -0600 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Rob Herring (Arm)" Cc: Linus Walleij , Alexandre Belloni , linux-rtc@vger.kernel.org, Stephen Boyd , Matti Vaittinen , Liam Girdwood , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Pavel Machek , linux-leds@vger.kernel.org, Sebastian Reichel , Conor Dooley , Michael Turquette , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Matti Vaittinen , Mark Brown , Andreas Kemnade , Lee Jones , linux-clk@vger.kernel.org, Krzysztof Kozlowski To: Matti Vaittinen In-Reply-To: References: Message-Id: <176233321101.143066.16817673032324313304.robh@kernel.org> Subject: Re: [PATCH v3 04/16] dt-bindings: power: supply: BD72720 managed battery On Wed, 05 Nov 2025 09:36:49 +0200, Matti Vaittinen wrote: > From: Matti Vaittinen > > The BD72720 PMIC has a battery charger + coulomb counter block. These > can be used to manage charging of a lithium-ion battery and to do fuel > gauging. > > ROHM has developed a so called "zero-correction" -algorithm to improve > the fuel-gauging accuracy close to the point where battery is depleted. > This relies on battery specific "VDR" tables, which are measured from > the battery, and which describe the voltage drop rate. More thorough > explanation about the "zero correction" and "VDR" parameters is here: > https://lore.kernel.org/all/676253b9-ff69-7891-1f26-a8b5bb5a421b@fi.rohmeurope.com/ > > Document the VDR zero-correction specific battery properties used by the > BD72720 and some other ROHM chargers. > > Signed-off-by: Matti Vaittinen > Reviewed-by: Linus Walleij > > --- > NOTE: > Linus' rb-tag holds only if there's no further comments from Rob. > > Revision history: > v2 => v3: > - Constrain VDR threshold voltage to 48V > - Use standard '-bp' -suffix for the rohm,volt-drop-soc > > RFCv1 => v2: > - Add units to rohm,volt-drop-soc (tenths of %) > - Give real temperatures matching the VDR tables, instead of vague > 'high', 'normal', 'low', 'very low'. (Add table of temperatures and > use number matching the right temperature index in the VDR table name). > - Fix typoed 'algorithm' in commit message. > > The parameters are describing the battery voltage drop rates - so they > are properties of the battery, not the charger. Thus they do not belong > in the charger node. > > The right place for them is the battery node, which is described by the > generic "battery.yaml". I was not comfortable with adding these > properties to the generic battery.yaml because they are: > - Meaningful only for those charger drivers which have the VDR > algorithm implemented. (And even though the algorithm is not charger > specific, AFAICS, it is currently only used by some ROHM PMIC > drivers). > - Technique of measuring the VDR tables for a battery is not widely > known. AFAICS, only folks at ROHM are measuring those for some > customer products. We do have those tables available for some of the > products though (Kobo?). > --- > .../power/supply/rohm,vdr-battery.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/rohm,vdr-battery.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/rohm,vdr-battery.example.dtb: battery (simple-battery): 'degrade-cycle-microamp-hours', 'rohm,volt-drop-0-microvolt', 'rohm,volt-drop-1-microvolt', 'rohm,volt-drop-2-microvolt', 'rohm,volt-drop-3-temp-microvolt', 'rohm,volt-drop-soc-bp', 'rohm,volt-drop-temperatures-millicelsius', 'rohm,voltage-vdr-thresh-microvolt' do not match any of the regexes: '^ocv-capacity-table-[0-9]+$', '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/power/supply/battery.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/a45e7230ecd08eed2081cbe7e7b4719d1fc8a581.1762327887.git.mazziesaccount@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.