From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D61A1C61DA4 for ; Thu, 2 Feb 2023 09:38:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbjBBJin (ORCPT ); Thu, 2 Feb 2023 04:38:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231718AbjBBJik (ORCPT ); Thu, 2 Feb 2023 04:38:40 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16DA683048 for ; Thu, 2 Feb 2023 01:38:38 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id t7so1113843wrp.5 for ; Thu, 02 Feb 2023 01:38:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1SVU6QigYfI43kWNTeLwwoyCrnQDbgOxVnxRJ80sFMw=; b=DGkg38jlZDUTz15Z4tOwAS3Anphznwxrli3xvDOZRnNl6r8/CayV5FrtmrR4Vsxpa0 gyFTfObawwlIt4jLoiZ6LsIvFzwWiOfRcKyIEv3Xy3382u8K23U2B0SmXVJUgNogx3xX HdKFBy1X57O5dDcYNnIgd8qxJndlpOq7wNV15Uq2pDwKOrDZD/VawfOzCQQYr4rtq+bz xxczjZGFR3JwzXOxGDY7g/TiwZk5m8ZSWIbd2bCE9i6GXtDZNZfkys7nxW9lcCka+8hP cSsG78iW1elHk6WSThjlAbw3CG4HwHfOf/IShBlWETBYNkFXP+3c/oXVC7yI+Xzz450g 4JYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1SVU6QigYfI43kWNTeLwwoyCrnQDbgOxVnxRJ80sFMw=; b=GPW+Vi5NNkxp7htK1uMDVa+KutsBm0oAFKeyufVHJdDlhpZv7xcWZITc44sT4ay0qX mkQhUUvyR7CKnjvOtXQRITfhI0KnI/PNjFk/LHS2RokP0TwF2YLG/BPAWAMB+pMyuElH XqLP6iFFrKVrl9BAWnIQg13rkZGDEWZjz6F5zCugiqXifh2pI1NwWD+j9DB+wOR6xuF7 fYc8ONdeMQglGiFWnuHmKpm2lhxWcDXJOU8wWDEGg4lE1uaKJISnMVLQaVaepnYy3oPm /9l76ohsLccfOippJyfF+Xkj79enee9fSu7Xk83jEZwpf1GukUmbFIdXo3m2kboPrGMk Guiw== X-Gm-Message-State: AO0yUKV9PdbN8zO4p9bijj9BdUFx2riComHN1FNriNFllS0fcw/fwOFO vzUE6cKvBNb3NNFwQZWhi5Z91w== X-Google-Smtp-Source: AK7set/YtuHJ/gLfQ7R747dzj3cK1k46TG7Tyv3bSIJY4mF9pBcvOhfX3zWGEcm+q27k7hoJOBQ0uA== X-Received: by 2002:a05:6000:184a:b0:2bf:bc75:1730 with SMTP id c10-20020a056000184a00b002bfbc751730mr5852303wri.70.1675330716631; Thu, 02 Feb 2023 01:38:36 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id j9-20020a5d6189000000b002c285b4d2b5sm6437113wru.101.2023.02.02.01.38.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 01:38:36 -0800 (PST) Message-ID: <176bf263-a12d-2cb3-d67c-3d7c3a0c7c31@linaro.org> Date: Thu, 2 Feb 2023 10:38:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 7/7] dt-bindings: pinctrl: qcom: correct gpio-ranges in examples Content-Language: en-US To: Stephan Gerhold Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Richard Acayan , Vinod Koul , krishna Lanka , Iskren Chernev , Martin Botka , Abel Vesa , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230201153019.269718-1-krzysztof.kozlowski@linaro.org> <20230201153019.269718-7-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 01/02/2023 17:31, Stephan Gerhold wrote: > On Wed, Feb 01, 2023 at 05:07:40PM +0100, Stephan Gerhold wrote: >> On Wed, Feb 01, 2023 at 04:30:19PM +0100, Krzysztof Kozlowski wrote: >>> Correct the number of GPIOs in gpio-ranges to match reality. >>> >>> Signed-off-by: Krzysztof Kozlowski >> >> AFAICT the current gpio-ranges do match the number of GPIOs (ngpios) in >> the pinctrl drivers for all/most of the platforms you update below. It >> looks like the special UFS_RESET pins are also exported as GPIOs in >> addition to the real GPIOs. I'm not sure if this is intended or a >> mistake. >> > > It looks like this is on purpose: > > --- > From 53a5372ce326116f3e3d3f1d701113b2542509f4 Mon Sep 17 00:00:00 2001 > From: Bjorn Andersson > Date: Tue, 4 Jun 2019 00:19:59 -0700 > Subject: [PATCH] pinctrl: qcom: sdm845: Expose ufs_reset as gpio > > The ufs_reset pin is expected to be wired to the reset pin of the > primary UFS memory but is pretty much just a general purpose output pinr > > Reorder the pins and expose it as gpio 150, so that the UFS driver can > toggle it. > --- > > And it's used in sdm845-mtp.dts: > > &ufs_mem_hc { > reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>; > }; > > So I think this patch (together with the DT ones you sent) should be > dropped because it would prevent using the UFS_RESET as GPIO since it's > no longer included in gpio-ranges. Thanks, but then we need to fix few others which miss the UFS reset pin. Best regards, Krzysztof