From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31F82C47254 for ; Sat, 9 May 2020 09:41:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1146924958 for ; Sat, 9 May 2020 09:41:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727812AbgEIJlN (ORCPT ); Sat, 9 May 2020 05:41:13 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:50948 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726885AbgEIJlN (ORCPT ); Sat, 9 May 2020 05:41:13 -0400 Received: from 89-77-60-66.dynamic.chello.pl (89.77.60.66) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.415) id 27d721ed7a9161ea; Sat, 9 May 2020 11:41:10 +0200 From: "Rafael J. Wysocki" To: Hans de Goede Cc: Len Brown , Bjorn Helgaas , Mika Westerberg , Andy Shevchenko , Linus Walleij , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 2/2] ACPI / hotplug / PCI: Use the new acpi_evaluate_reg() helper Date: Sat, 09 May 2020 11:41:10 +0200 Message-ID: <1840051.TrPhkc76kE@kreacher> In-Reply-To: <20200507104917.116589-2-hdegoede@redhat.com> References: <20200507104917.116589-1-hdegoede@redhat.com> <20200507104917.116589-2-hdegoede@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thursday, May 7, 2020 12:49:17 PM CEST Hans de Goede wrote: > Use the new acpi_evaluate_reg() helper in the acpiphp_glue.c code. > > Acked-by: Bjorn Helgaas > Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- > Changes in v2: > - Leave comment about not caring about _REG errors in place > - Add Bjorn's Acked-by > - Add Andy's Reviewed-by > --- > drivers/pci/hotplug/acpiphp_glue.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c > index b3869951c0eb..b4c92cee13f8 100644 > --- a/drivers/pci/hotplug/acpiphp_glue.c > +++ b/drivers/pci/hotplug/acpiphp_glue.c > @@ -385,19 +385,12 @@ static unsigned char acpiphp_max_busnr(struct pci_bus *bus) > static void acpiphp_set_acpi_region(struct acpiphp_slot *slot) > { > struct acpiphp_func *func; > - union acpi_object params[2]; > - struct acpi_object_list arg_list; > > list_for_each_entry(func, &slot->funcs, sibling) { > - arg_list.count = 2; > - arg_list.pointer = params; > - params[0].type = ACPI_TYPE_INTEGER; > - params[0].integer.value = ACPI_ADR_SPACE_PCI_CONFIG; > - params[1].type = ACPI_TYPE_INTEGER; > - params[1].integer.value = 1; > /* _REG is optional, we don't care about if there is failure */ > - acpi_evaluate_object(func_to_handle(func), "_REG", &arg_list, > - NULL); > + acpi_evaluate_reg(func_to_handle(func), > + ACPI_ADR_SPACE_PCI_CONFIG, > + ACPI_REG_CONNECT); > } > } > > Applied as 5.8 material along with the [1/2], thanks!