From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] pinctrl: rockchip: Add set_config callback support for gpiolib Date: Tue, 15 May 2018 14:38:37 +0200 Message-ID: <18645454.vOLSfLOOiQ@phil> References: <1525334682-222918-1-git-send-email-shawn.lin@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1525334682-222918-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Shawn Lin Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linus Walleij , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-gpio@vger.kernel.org Am Donnerstag, 3. Mai 2018, 10:04:42 CEST schrieb Shawn Lin: > Could only support PIN_CONFIG_INPUT_DEBOUNCE now as the HW block > is too simple to support others. But even wrt. debounce capability, > it now could only support very limited period of time to satisfy the > real usecase. But still be useful to enable the crippled HW debounce > to prevent any spurious glitches from waking up the system if the > gpio is conguired as wakeup interrupt source. > > Signed-off-by: Shawn Lin >>From the argument given, this sounds sane to me, also about not changing the behaviour (as noted in the comment in _set_config) and the code looks also good to me, so from my non electrical pov Reviewed-by: Heiko Stuebner Heiko