From: Arnd Bergmann <arnd@arndb.de>
To: Y Vo <yvo@apm.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>, Phong Vo <pvo@apm.com>,
Toan Le <toanle@apm.com>, Tin Huynh <tnhuynh@apm.com>,
patches <patches@apm.com>
Subject: Re: [PATCH v1 1/3] gpio: Add APM X-Gene standby GPIO controller driver
Date: Tue, 16 Dec 2014 10:56:16 +0100 [thread overview]
Message-ID: <1878846.YCCkHOWfdd@wuerfel> (raw)
In-Reply-To: <CAL4ahLfSZjmqqbQ9Xmqae_AVfFZLiUUEN+rABMwiu2_8u4mmPQ@mail.gmail.com>
On Tuesday 16 December 2014 16:43:02 Y Vo wrote:
> >> +static int xgene_gpio_sb_get(struct gpio_chip *gc, u32 gpio)
> >> +{
> >> + struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
> >> + struct xgene_gpio_sb *chip = to_xgene_gpio_sb(mm_gc);
> >> + u32 data;
> >> +
> >> + data = ioread32(mm_gc->regs + MPA_GPIO_IN_ADDR);
> >> +
> >> + return (data & GPIO_MASK(gpio)) ? 1 : 0;
> >> +}
> >
> > This would be actually broken, right? Maybe it's better to change the
> > driver so that it refuses to map GPIO lines that are hardwired to
> > the interrupt controller, until we can support that.
>
> It still works if they are configure as GPIO.
> Do you have any reference to resolve it ?
Ok, I think I just misunderstood how this works, I assumed that you
could not reconfigure the lines. Seems ok then.
Arnd
next prev parent reply other threads:[~2014-12-16 9:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 14:52 [PATCH v1 0/3] gpio: Add APM X-Gene standy platform GPIO driver Y Vo
2014-10-08 14:52 ` [PATCH v1 2/3] Documentation: gpio: Add APM X-Gene standby GPIO controller DTS binding Y Vo
[not found] ` <1412779948-28769-1-git-send-email-yvo-qTEPVZfXA3Y@public.gmane.org>
2014-10-08 14:52 ` [PATCH v1 1/3] gpio: Add APM X-Gene standby GPIO controller driver Y Vo
2014-10-08 15:13 ` Arnd Bergmann
[not found] ` <CAL4ahLfpubEqi49gy8T9pyrf=1j__LbAsKUyr5i=koNyp0Mmig@mail.gmail.com>
2014-10-09 12:13 ` Arnd Bergmann
2014-10-10 3:22 ` Y Vo
2014-10-10 7:26 ` Arnd Bergmann
2014-10-24 12:14 ` Linus Walleij
2014-10-24 13:46 ` Arnd Bergmann
2014-10-29 9:52 ` Linus Walleij
2014-10-29 10:24 ` Arnd Bergmann
2014-10-29 15:09 ` Y Vo
2014-10-29 15:16 ` Arnd Bergmann
2014-12-16 9:43 ` Y Vo
2014-12-16 9:56 ` Arnd Bergmann [this message]
2014-10-08 14:52 ` [PATCH v1 3/3] arm64:dts: Add APM X-Gene standby GPIO controller DTS entries Y Vo
2014-10-09 9:42 ` [PATCH v1 0/3] gpio: Add APM X-Gene standy platform GPIO driver Mark Rutland
2014-10-09 11:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1878846.YCCkHOWfdd@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=patches@apm.com \
--cc=pvo@apm.com \
--cc=tnhuynh@apm.com \
--cc=toanle@apm.com \
--cc=yvo@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).