Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
	Alexandre Courbot <acourbot@nvidia.com>,
	Magnus Damm <damm@opensource.se>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: Re: [PATCH] gpio: rcar: drop references to "virtual" IRQ
Date: Fri, 11 Oct 2013 21:48:37 +0200	[thread overview]
Message-ID: <1882093.YGqDmvRXf2@avalon> (raw)
In-Reply-To: <1381513489-8044-1-git-send-email-linus.walleij@linaro.org>

Hi Linus,

Thanks for the patch.

On Friday 11 October 2013 19:44:49 Linus Walleij wrote:
> Rename the argument "virq" to just "irq", this IRQ isn't any
> more "virtual" than any other Linux IRQ number, we use "hwirq"
> for the actual hw-numbers, "virq" is just bogus.
> 
> Cc: Magnus Damm <damm@opensource.se>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

As you maintain the GPIO tree, I don't think there's a need for me to take the 
patch in my tree and then send you a pull request, is there ? :-)

> ---
>  drivers/gpio/gpio-rcar.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index e3745eb..65dbf87 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -266,16 +266,16 @@ static int gpio_rcar_to_irq(struct gpio_chip *chip,
> unsigned offset) return irq_create_mapping(gpio_to_priv(chip)->irq_domain,
> offset); }
> 
> -static int gpio_rcar_irq_domain_map(struct irq_domain *h, unsigned int
> virq, -				 irq_hw_number_t hw)
> +static int gpio_rcar_irq_domain_map(struct irq_domain *h, unsigned int irq,
> +				 irq_hw_number_t hwirq)
>  {
>  	struct gpio_rcar_priv *p = h->host_data;
> 
> -	dev_dbg(&p->pdev->dev, "map hw irq = %d, virq = %d\n", (int)hw, virq);
> +	dev_dbg(&p->pdev->dev, "map hw irq = %d, irq = %d\n", (int)hwirq, irq);
> 
> -	irq_set_chip_data(virq, h->host_data);
> -	irq_set_chip_and_handler(virq, &p->irq_chip, handle_level_irq);
> -	set_irq_flags(virq, IRQF_VALID); /* kill me now */
> +	irq_set_chip_data(irq, h->host_data);
> +	irq_set_chip_and_handler(irq, &p->irq_chip, handle_level_irq);
> +	set_irq_flags(irq, IRQF_VALID); /* kill me now */
>  	return 0;
>  }
-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2013-10-11 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11 17:44 [PATCH] gpio: rcar: drop references to "virtual" IRQ Linus Walleij
2013-10-11 19:48 ` Laurent Pinchart [this message]
2013-10-14  7:01   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1882093.YGqDmvRXf2@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=acourbot@nvidia.com \
    --cc=damm@opensource.se \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox