From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3695B156864 for ; Wed, 28 Aug 2024 07:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724829059; cv=none; b=iNjmRjp5RhsHvsbwCRlMbBLqQZ8ZvR6YgOh9UQAgqxMs2jG2ZoT0kqv15K0tqAoKmJOFefTSntuAu1AvrWQCU92V5XuvLIzQnnOn/I/0LZtfLSvmu23y+cOJ4UKiMlSKvVC+a0KruhA3QIWwa2hd8fa+5ZpB7BfVn2wMkOgtrrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724829059; c=relaxed/simple; bh=hrdybWADZxrNOGDFQ+iblbPSFaRlDH4YMdydN364uxU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=F/R9vr2uifOUEFzjW7Vxz9rSc0TNzC3BTj2bM8wkO9nIap80k7pEFzIThdNpLLtTrMIHkAf10N5GdEBAbOBawcmXwzwfce2ONDoN2wJZES6Cg0EuxF7aT6ph1aX7tnEjK+qwCxy3aTdcY4df3jHO2w3+9ZdkAVJB0lT/16bXmlw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b25dXY6y; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b25dXY6y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724829056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4exFj43hWLT00BAGeYDHEqubvTOHjaJM+W+ukum/0tY=; b=b25dXY6yCnFhBPxNzTGVXpsjAEJZ0nyy02OSQJlrxhjbd8L9SyTACOoQjF9JK/ADVFaK/t F68qNganpDe3QWhY+WI6wr03D3U7hNJ0T4iwLXnHQOqXpwcnf+3yri8KkoLKKGSDges3X0 GWRAv47tfQHReADcb2Izs4/Xp2l5abs= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-375-G0IrnyXkMTS0BdLMknhchA-1; Wed, 28 Aug 2024 03:10:53 -0400 X-MC-Unique: G0IrnyXkMTS0BdLMknhchA-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7a7d9c328c9so401372785a.1 for ; Wed, 28 Aug 2024 00:10:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724829052; x=1725433852; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4exFj43hWLT00BAGeYDHEqubvTOHjaJM+W+ukum/0tY=; b=TGXRaYmOR3Qk4+yAqbIswUjtwGJo7Bk5bjyCGs0phpfKIc8RBR8ukc9isOwcvNw/v1 fqg/gRGbIo8NhanYXyXHnKr9Okf8sD7DAB+BgtIwaI9HWtWPj75uhHvOe2LZUzysVMHJ TifzA3TkbIkO8AI4wJe8i+F8e75EVZCCCQ3WclygRCCNxbWfP9vtMbHjCYbaXegA8FX7 xHBqvpP7QpJ+TECp0oo/XpLpAZ+OOdkEBUV/cS44xqi1x1Pn4evAavXg0kjafnie3D5V Tr58Soj2GQTwsWJdHYGyeEkZB1u5hHxxxAL3UCkrOnrt/tFF8RoghPrXkJ/cpYKO927q qOmA== X-Forwarded-Encrypted: i=1; AJvYcCXD9gcKDbwxiQ+wCu+SXAcSMCE2bhbH1eWR5zXceL61jMceEkBig2Ry8yP8ZPsw28xMrsc5880LfJdn@vger.kernel.org X-Gm-Message-State: AOJu0Yzcb5FL1rORyPhi3Ersn3ROe5yIwJx7Pymn+s3VM48o2GyI9P+u Fr7YV2ifqdXEhpIDQO4siHo0Q/5wnZmXgKFMlmvr4X5SD45fT29tYb3L+zXfRefoYtrFgMoAPIo IUQvS3/dZ1ObSccWKkNRHcBcYMSMazcmEELSOE1VFEbqJ1Lf8FtZjDnS/1xk= X-Received: by 2002:a05:620a:468b:b0:79d:6276:927a with SMTP id af79cd13be357-7a68970207amr1677960985a.22.1724829052405; Wed, 28 Aug 2024 00:10:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHoJpkEEQicGfWPZT1lOW4zceJ6tHVmY2Rb8P+ysJBwyYwzs7rm3IwCsm6DsOeUMwreCEmk+Q== X-Received: by 2002:a05:620a:468b:b0:79d:6276:927a with SMTP id af79cd13be357-7a68970207amr1677958385a.22.1724829051978; Wed, 28 Aug 2024 00:10:51 -0700 (PDT) Received: from dhcp-64-16.muc.redhat.com (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a67f319050sm617950485a.11.2024.08.28.00.10.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 00:10:51 -0700 (PDT) Message-ID: <189ab84e8af230092ff94cc3f3addb499b1a581d.camel@redhat.com> Subject: Re: [PATCH v4 3/7] block: mtip32xx: Replace deprecated PCI functions From: Philipp Stanner To: Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bjorn Helgaas , Alvaro Karsz , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?ISO-8859-1?Q?P=E9rez?= , Richard Cochran , Damien Le Moal , Hannes Reinecke , Keith Busch Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev Date: Wed, 28 Aug 2024 09:10:47 +0200 In-Reply-To: References: <20240827185616.45094-1-pstanner@redhat.com> <20240827185616.45094-4-pstanner@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2024-08-27 at 13:05 -0600, Jens Axboe wrote: > On 8/27/24 12:56 PM, Philipp Stanner wrote: > > pcim_iomap_regions() and pcim_iomap_table() have been deprecated by > > the > > PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate > > pcim_iomap_table(), pcim_iomap_regions_request_all()"). > >=20 > > In mtip32xx, these functions can easily be replaced by their > > respective > > successors, pcim_request_region() and pcim_iomap(). Moreover, the > > driver's calls to pcim_iounmap_regions() in probe()'s error path > > and in > > remove() are not necessary. Cleanup can be performed by PCI devres > > automatically. > >=20 > > Replace pcim_iomap_regions() and pcim_iomap_table(). > >=20 > > Remove the calls to pcim_iounmap_regions(). >=20 > Looks fine to me - since it depends on other trees, feel free to take > it > through those: >=20 > Reviewed-by: Jens Axboe Thank you for the review. I have to provide a v5 because of an issue in another patch. While I'm at it, I'd modify this patch here so that the comment above pcim_request_region() is descriptive of the actual events: - /* Map BAR5 to memory. */ + /* Request BAR5. */ I'd keep your Reviewed-by if that's OK. It's the only change I'd do. Regards, P.