From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?U8O2cmVu?= Brinkmann Subject: Re: [PATCH] usb: phy-generic: Don't fail on missing gpio reset Date: Tue, 27 Jan 2015 11:13:08 -0800 Message-ID: <19e48726b36942cfb0430fc625b41e1b@BY2FFO11FD043.protection.gbl> References: <1422323129-20969-1-git-send-email-soren.brinkmann@xilinx.com> <20150127152047.GA13776@saruman.tx.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-bl2on0088.outbound.protection.outlook.com ([65.55.169.88]:19776 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758210AbbA0TNV (ORCPT ); Tue, 27 Jan 2015 14:13:21 -0500 Content-Disposition: inline In-Reply-To: <20150127152047.GA13776@saruman.tx.rr.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Felipe Balbi Cc: Andreas =?utf-8?Q?F=C3=A4rber?= , Michal Simek , devicetree@vger.kernel.org, Peter Crosthwaite , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ola Jeppson , linux-gpio@vger.kernel.org, linux-usb@vger.kernel.org On Tue, 2015-01-27 at 09:20AM -0600, Felipe Balbi wrote: > On Mon, Jan 26, 2015 at 05:45:29PM -0800, Soren Brinkmann wrote: > > A reset through a GPIO is optional. Don't fail probing when it is > > missing. > >=20 > > Reported-by: Andreas F=C3=A4rber > > Signed-off-by: Soren Brinkmann > > --- > > Hi Andreas, > >=20 > > does this do the trick? > >=20 > > Thanks, > > S=C3=B6ren > >=20 > > drivers/usb/phy/phy-generic.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > >=20 > > diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-ge= neric.c > > index dd05254241fb..a73d4c738f0b 100644 > > --- a/drivers/usb/phy/phy-generic.c > > +++ b/drivers/usb/phy/phy-generic.c > > @@ -241,10 +241,8 @@ int usb_phy_gen_create_phy(struct device *dev,= struct usb_phy_generic *nop, > > =20 > > if (err =3D=3D -EPROBE_DEFER) > > return -EPROBE_DEFER; > > - if (err) { > > - dev_err(dev, "Error requesting RESET GPIO\n"); > > - return err; > > - } > > + if (err) > > + nop->gpiod_reset =3D NULL; >=20 > there's a better patch to use gpiod_get_optional(), instead. Great, apparently that wasn't in linux-next yesterday. I'll give it a shot once it arrives there. S=C3=B6ren -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html