From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: linus.walleij@linaro.org, bgolaszewski@baylibre.com
Cc: akpm@linux-foundation.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk,
yamada.masahiro@socionext.com,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
geert@linux-m68k.org, preid@electromag.com.au, lukas@wunner.de,
sean.nyekjaer@prevas.dk, morten.tiljeset@prevas.dk,
William Breathitt Gray <vilhelm.gray@gmail.com>
Subject: [PATCH v16 12/14] gpio: pisosr: Utilize the for_each_set_clump8 macro
Date: Sun, 6 Oct 2019 11:11:09 -0400 [thread overview]
Message-ID: <19e98b4a648026055d0642d238dbf5ed5a4b4117.1570374078.git.vilhelm.gray@gmail.com> (raw)
In-Reply-To: <cover.1570374078.git.vilhelm.gray@gmail.com>
Replace verbose implementation in get_multiple callback with
for_each_set_clump8 macro to simplify code and improve clarity.
Cc: Morten Hein Tiljeset <morten.tiljeset@prevas.dk>
Cc: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/gpio/gpio-pisosr.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c
index f809a5a8e9eb..9ab2c044ef52 100644
--- a/drivers/gpio/gpio-pisosr.c
+++ b/drivers/gpio/gpio-pisosr.c
@@ -96,16 +96,16 @@ static int pisosr_gpio_get_multiple(struct gpio_chip *chip,
unsigned long *mask, unsigned long *bits)
{
struct pisosr_gpio *gpio = gpiochip_get_data(chip);
- unsigned int nbytes = DIV_ROUND_UP(chip->ngpio, 8);
- unsigned int i, j;
+ unsigned long offset;
+ unsigned long gpio_mask;
+ unsigned long buffer_state;
pisosr_gpio_refresh(gpio);
bitmap_zero(bits, chip->ngpio);
- for (i = 0; i < nbytes; i++) {
- j = i / sizeof(unsigned long);
- bits[j] |= ((unsigned long) gpio->buffer[i])
- << (8 * (i % sizeof(unsigned long)));
+ for_each_set_clump8(offset, gpio_mask, mask, chip->ngpio) {
+ buffer_state = gpio->buffer[offset / 8] & gpio_mask;
+ bitmap_set_value8(bits, buffer_state, offset);
}
return 0;
--
2.23.0
next prev parent reply other threads:[~2019-10-06 15:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 15:10 [PATCH v16 00/14] Introduce the for_each_set_clump8 macro William Breathitt Gray
2019-10-06 15:10 ` [PATCH v16 01/14] bitops: " William Breathitt Gray
2019-10-07 8:21 ` Andy Shevchenko
2019-10-07 15:18 ` William Breathitt Gray
2019-10-06 15:10 ` [PATCH v16 02/14] lib/test_bitmap.c: Add for_each_set_clump8 test cases William Breathitt Gray
2019-10-06 15:11 ` [PATCH v16 03/14] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro William Breathitt Gray
2019-10-06 15:11 ` [PATCH v16 04/14] gpio: 104-idi-48: " William Breathitt Gray
2019-10-06 15:11 ` [PATCH v16 05/14] gpio: gpio-mm: " William Breathitt Gray
2019-10-06 15:11 ` [PATCH v16 06/14] gpio: ws16c48: " William Breathitt Gray
2019-10-06 15:11 ` [PATCH v16 07/14] gpio: pci-idio-16: " William Breathitt Gray
2019-10-06 15:11 ` [PATCH v16 08/14] gpio: pcie-idio-24: " William Breathitt Gray
2019-10-06 15:11 ` [PATCH v16 09/14] gpio: uniphier: " William Breathitt Gray
2019-10-06 15:11 ` [PATCH v16 10/14] gpio: 74x164: Utilize the " William Breathitt Gray
2019-10-07 8:24 ` Andy Shevchenko
2019-10-06 15:11 ` [PATCH v16 11/14] thermal: intel: intel_soc_dts_iosf: Utilize " William Breathitt Gray
2019-10-07 8:44 ` Andy Shevchenko
2019-10-06 15:11 ` William Breathitt Gray [this message]
2019-10-06 15:11 ` [PATCH v16 13/14] gpio: max3191x: Utilize the " William Breathitt Gray
2019-10-06 15:11 ` [PATCH v16 14/14] gpio: pca953x: " William Breathitt Gray
2019-10-07 8:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19e98b4a648026055d0642d238dbf5ed5a4b4117.1570374078.git.vilhelm.gray@gmail.com \
--to=vilhelm.gray@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lukas@wunner.de \
--cc=morten.tiljeset@prevas.dk \
--cc=preid@electromag.com.au \
--cc=sean.nyekjaer@prevas.dk \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).