From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F53622B8C4 for ; Thu, 6 Feb 2025 11:49:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738842572; cv=none; b=Ph+9LnjDAy8c8xpIHyNRLkIpw4DZz/2FWPz9WxiwQUyRF4VTGLdsnbI5UMvOG8jhM1vbqb1r4XdV7lBss6nOmW7scdOrniCatrGdcY7qWuwnqMmA7NIepabaTiNXuY5/Y2Dksb+0fcJEggQmZf8Roqo3jTR4XL5XIjUS5YJphGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738842572; c=relaxed/simple; bh=E8+d7rzKIQYxvCPsaoYc55cIInzpgJbkEM+e7bop0Aw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=luShGzqcMVK84cMTj+mpA6HReU9LzhF533QpxFPVokrrisElFMZIYPQP3ox5zpQHnPnCN/BSN1lMtCuMGz05VGtk0RTWp2TXZ53FqGtotNy3faUyXPxMGLXjjUgItIIlEBWgoDIdDXrOHi+x2cgkNHJq4lB6MNrkejbaLlSV4qU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=i2INX94n; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i2INX94n" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4361c705434so5434645e9.3 for ; Thu, 06 Feb 2025 03:49:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738842568; x=1739447368; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NX9ms/4I8NC6zrc1aMCv7TAeR5qd6HJ58Z3muKUA91A=; b=i2INX94nzv1I+RFUk8aoJSG6QACu6LLaG8v2He3L2jxp68dSvdt6TOr9WmR0pwBdTv oDghr28FuERI+3HnT9l67fmynAoVlwXmDRDernVRVFgBhI1OGlC3p6CaPQur0hKTMKf6 CZTj7YmLj40UrRPNjyW/oXef0tVxeJ2Ov/2+uiM3wTyEZzK8+MYDbirTOZe7TQsIG8X9 Z18YIl8vPE1WT0TEkbZlZDbDNvZJDGfjKcVHEvy+wrlKuMcuSCXVdPIIPyPrHajupXkM 6jFbfDzLsWFLQLDD+lHuJEG15e980QlMdH7tNzCFBASz+fckwTtvLAG0S2pFYL7Bzerq rETw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738842568; x=1739447368; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NX9ms/4I8NC6zrc1aMCv7TAeR5qd6HJ58Z3muKUA91A=; b=XG4ZtNSKVaFQPyUBf+eFOsQPfO5v5UQ4zMKMVsumR5wSenYsswKWO9PAmWB3PiH5H0 6q/LRLNqy9Ak432jMfjCIAlKUGOtI+4BqyTcJFQnmlO/cuem7cVksezcRzU/huMCn7JY In8Tn0NPjTakxi7IJsWMk5mC85EasHFeDGVinqw3CzScY4ZfMvmlYGFU4Qa80BWDIpp5 NaPGYiJqSU972CAsP1mWYNQYX0YLEr0XYc5Stqln0FVDTTU5ROxkHDULzWtMTECC2q4v U2vd5emCMtzAo1GjJ8BpGhvvK0McxFhogd0L5LN0yz9r0JphwlBsDxJAaWZopdVGR2Pm zArw== X-Forwarded-Encrypted: i=1; AJvYcCUvRhQxwE/u45Ni6MSMZn5IbW9ePVNaqngmFZu2joOmmb5A662Tptt727ZMsb4X++1txVws9W4TJA1a@vger.kernel.org X-Gm-Message-State: AOJu0YyEJHgV6GF30bRSzY561tk+wWor9kfuwvS03ektQcIlgW15CqfG bMVp0LwzyldeyJcG6S6810AIhtdkcpBrfkIqQqQh4HRTaEw/OXxi4S12vou+zeA= X-Gm-Gg: ASbGncs6G6YExb1ctpuezIK2tZYwHx4aJNyUZoG403HJp/ztJVcerbbe4eR0/UNiX8G jIz8j32Mbbt3Yn8+nwMyAXJuuOHdjyNz9qY13nMD8aY2+zeQSuqz+8hnVbP0BLKyz9TCcx3xCZl avFT0yfgAGCzwGYF4I4os6iNssIUwfJrE6CZATegCTui09oRrliJGS7LHCDO1ErrmX/SWx9lX9M bv7a1qNQoH+doYUYsK2pw01iaQhCqmaagUqXIkeC5o0cNu7nBQbW7ZGfmjume9nKYrRclYxkFzp P1nOs7BkBenCNQxZC9ma X-Google-Smtp-Source: AGHT+IGBjV9LowhqFquW+OEjP5fmaVEQ40WZqgqqY5aomaJpQL2ZwcJcaosKDFlLLto2p8sEGWzZkQ== X-Received: by 2002:a05:600c:46d4:b0:434:f767:68ea with SMTP id 5b1f17b1804b1-4390d42ccb9mr56959955e9.5.1738842568525; Thu, 06 Feb 2025 03:49:28 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4390d94d685sm52793145e9.13.2025.02.06.03.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 03:49:28 -0800 (PST) Date: Thu, 6 Feb 2025 14:49:25 +0300 From: Dan Carpenter To: Cristian Marussi Cc: Peng Fan , Sudeep Holla , Saravana Kannan , Linus Walleij , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, imx@lists.linux.dev, Peng Fan Subject: Re: [PATCH v2 1/4] firmware: arm_scmi: Bypass setting fwnode for scmi cpufreq Message-ID: <1a420172-de2f-4602-a181-be79bff0bb2b@stanley.mountain> References: <20250120-scmi-fwdevlink-v2-0-3af2fa37dbac@nxp.com> <20250120-scmi-fwdevlink-v2-1-3af2fa37dbac@nxp.com> <7a29ec8f-fef8-4f1c-a2eb-16a63f2b820c@stanley.mountain> <20250206105218.GA22527@localhost.localdomain> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 06, 2025 at 11:42:12AM +0000, Cristian Marussi wrote: > On Thu, Feb 06, 2025 at 02:31:19PM +0300, Dan Carpenter wrote: > > On Thu, Feb 06, 2025 at 06:52:20PM +0800, Peng Fan wrote: > > > On Wed, Feb 05, 2025 at 03:45:00PM +0300, Dan Carpenter wrote: > > > >On Mon, Jan 20, 2025 at 03:13:29PM +0800, Peng Fan (OSS) wrote: > > > >> diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c > > > >> index 2c853c84b58f530898057e4ab274ba76070de05e..7850eb7710f499888d32aebf5d99df63db8bfa26 100644 > > > >> --- a/drivers/firmware/arm_scmi/bus.c > > > >> +++ b/drivers/firmware/arm_scmi/bus.c > > > >> @@ -344,6 +344,21 @@ static void __scmi_device_destroy(struct scmi_device *scmi_dev) > > > >> device_unregister(&scmi_dev->dev); > > > >> } > > > >> > > > >> +static int > > > >> +__scmi_device_set_node(struct scmi_device *scmi_dev, struct device_node *np, > > > >> + int protocol, const char *name) > > > >> +{ > > > >> + /* cpufreq device does not need to be supplier from devlink perspective */ > > > >> + if ((protocol == SCMI_PROTOCOL_PERF) && !strcmp(name, "cpufreq")) { > > > > > > > >I don't love this... It seems like an hack. Could we put a flag > > > >somewhere instead? Perhaps in scmi_device? (I'm just saying that > > > >because that's what we're passing to this function). > > > > > > This means when creating scmi_device, a flag needs to be set which requires > > > to extend scmi_device_id to include a flag entry or else. > > > > > > As below in scmi-cpufreq.c > > > { SCMI_PROTOCOL_PERF, "cpufreq", SCMI_FWNODE_NO } > > > > > > > Yeah, I like that. > > > > - if ((protocol == SCMI_PROTOCOL_PERF) && !strcmp(name, "cpufreq")) { > > + if (scmi_dev->flags & SCMI_FWNODE_NO) { > > > > Or we could do something like "if (scmi_dev->no_fwnode) {" > > I proposed a flag a few review ago about this, it shoule come somehow > from the device_table above like Peng was proposing, so that a driver > can just declare that does NOT need fw_devlink. Great. I think we're on the same page then. regards, dan carpenter