[PATCH v2 0/2] pinctrl: qcom: Add the QCS9100 tlmm compatible

[PATCH v2 0/2] pinctrl: qcom: Add the QCS9100 tlmm compatible

[Tengfei Fan]

Introduce support for the QCS9100 SoC device tree (DTSI) and the
QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
While the QCS9100 platform is still in the early design stage, the
QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
mounts the QCS9100 SoC instead of the SA8775p SoC.

The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
all the compatible strings will be updated from "SA8775p" to "QCS9100".
The QCS9100 device tree patches will be pushed after all the device tree
bindings and device driver patches are reviewed.

The final dtsi will like:
https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/

The detailed cover letter reference:
https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
Changes in v2:
  - Split huge patch series into different patch series according to
    subsytems
  - Update patch commit message

prevous disscussion here:
[1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/

---
Tengfei Fan (2):
      dt-bindings: pinctrl: add qcs9100-tlmm compatible
      pinctrl: qcom: add the tlmm driver support for qcs9100 platform

 Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 5 ++++-
 drivers/pinctrl/qcom/pinctrl-sa8775p.c                           | 1 +
 2 files changed, 5 insertions(+), 1 deletion(-)
---
base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
change-id: 20240709-add_qcs9100_tlmm_compatible-7e9b8e1bff83

Best regards,
-- 
Tengfei Fan <quic_tengfan@quicinc.com>

[PATCH v2 1/2] dt-bindings: pinctrl: add qcs9100-tlmm compatible

[Tengfei Fan]

Add qcs9100-tlmm compatible for QCS9100 SoC.
QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
platform use non-SCMI resource. In the future, the SA8775p platform will
move to use SCMI resources and it will have new sa8775p-related device
tree. Consequently, introduce "qcs9100-tlmm" to describe non-SCMI based
pinctrl.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
index e9abbf2c0689..1bdec08efc4a 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
@@ -17,7 +17,10 @@ allOf:
 
 properties:
   compatible:
-    const: qcom,sa8775p-tlmm
+    items:
+      - enum:
+          - qcom,qcs9100-tlmm
+          - qcom,sa8775p-tlmm
 
   reg:
     maxItems: 1

-- 
2.25.1

Re: [PATCH v2 1/2] dt-bindings: pinctrl: add qcs9100-tlmm compatible

[Krzysztof Kozlowski]

On 09/07/2024 15:04, Tengfei Fan wrote:
> Add qcs9100-tlmm compatible for QCS9100 SoC.
> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> platform use non-SCMI resource. In the future, the SA8775p platform will
> move to use SCMI resources and it will have new sa8775p-related device
> tree. Consequently, introduce "qcs9100-tlmm" to describe non-SCMI based
> pinctrl.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> index e9abbf2c0689..1bdec08efc4a 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> @@ -17,7 +17,10 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: qcom,sa8775p-tlmm
> +    items:

Same comment as in other patchset, so apparently you made all of patches
in similar way. No need to add items.

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: pinctrl: add qcs9100-tlmm compatible

[Tengfei Fan]

On 7/10/2024 6:14 PM, Krzysztof Kozlowski wrote:
> On 09/07/2024 15:04, Tengfei Fan wrote:
>> Add qcs9100-tlmm compatible for QCS9100 SoC.
>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>> platform use non-SCMI resource. In the future, the SA8775p platform will
>> move to use SCMI resources and it will have new sa8775p-related device
>> tree. Consequently, introduce "qcs9100-tlmm" to describe non-SCMI based
>> pinctrl.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>> index e9abbf2c0689..1bdec08efc4a 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>> @@ -17,7 +17,10 @@ allOf:
>>   
>>   properties:
>>     compatible:
>> -    const: qcom,sa8775p-tlmm
>> +    items:
> 
> Same comment as in other patchset, so apparently you made all of patches
> in similar way. No need to add items.
> 
> Best regards,
> Krzysztof
> 

I will use an enum directly in all the patches with similar 
modifications in the next patch series.

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH v2 1/2] dt-bindings: pinctrl: add qcs9100-tlmm compatible

[Tengfei Fan]

On 7/10/2024 6:26 PM, Tengfei Fan wrote:
> 
> 
> On 7/10/2024 6:14 PM, Krzysztof Kozlowski wrote:
>> On 09/07/2024 15:04, Tengfei Fan wrote:
>>> Add qcs9100-tlmm compatible for QCS9100 SoC.
>>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>>> platform use non-SCMI resource. In the future, the SA8775p platform will
>>> move to use SCMI resources and it will have new sa8775p-related device
>>> tree. Consequently, introduce "qcs9100-tlmm" to describe non-SCMI based
>>> pinctrl.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>>   Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 
>>> 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml 
>>> b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>>> index e9abbf2c0689..1bdec08efc4a 100644
>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>>> @@ -17,7 +17,10 @@ allOf:
>>>   properties:
>>>     compatible:
>>> -    const: qcom,sa8775p-tlmm
>>> +    items:
>>
>> Same comment as in other patchset, so apparently you made all of patches
>> in similar way. No need to add items.
>>
>> Best regards,
>> Krzysztof
>>
> 
> I will use an enum directly in all the patches with similar 
> modifications in the next patch series.

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

> 

-- 
Thx and BRs,
Tengfei Fan

[PATCH v2 2/2] pinctrl: qcom: add the tlmm driver support for qcs9100 platform

[Tengfei Fan]

Add the tlmm driver support for QCS9100 platform.
QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
platform use non-SCMI resource. In the future, the SA8775p platform will
move to use SCMI resources and it will have new sa8775p-related device
tree. Consequently, introduce "qcom,qcs9100-tlmm" to the pinctrl device
match table.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 drivers/pinctrl/qcom/pinctrl-sa8775p.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/qcom/pinctrl-sa8775p.c b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
index 5459c0c681a2..4687e11dfe75 100644
--- a/drivers/pinctrl/qcom/pinctrl-sa8775p.c
+++ b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
@@ -1519,6 +1519,7 @@ static int sa8775p_pinctrl_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id sa8775p_pinctrl_of_match[] = {
+	{ .compatible = "qcom,qcs9100-tlmm", },
 	{ .compatible = "qcom,sa8775p-tlmm", },
 	{ },
 };

-- 
2.25.1

Re: [PATCH v2 2/2] pinctrl: qcom: add the tlmm driver support for qcs9100 platform

[Bartosz Golaszewski]

On Tue, 9 Jul 2024 at 15:05, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>
> Add the tlmm driver support for QCS9100 platform.
> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> platform use non-SCMI resource. In the future, the SA8775p platform will
> move to use SCMI resources and it will have new sa8775p-related device
> tree. Consequently, introduce "qcom,qcs9100-tlmm" to the pinctrl device
> match table.
>
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  drivers/pinctrl/qcom/pinctrl-sa8775p.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sa8775p.c b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
> index 5459c0c681a2..4687e11dfe75 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sa8775p.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
> @@ -1519,6 +1519,7 @@ static int sa8775p_pinctrl_probe(struct platform_device *pdev)
>  }
>
>  static const struct of_device_id sa8775p_pinctrl_of_match[] = {
> +       { .compatible = "qcom,qcs9100-tlmm", },
>         { .compatible = "qcom,sa8775p-tlmm", },
>         { },
>  };
>
> --
> 2.25.1
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH v2 2/2] pinctrl: qcom: add the tlmm driver support for qcs9100 platform

[Tengfei Fan]

On 7/9/2024 11:39 PM, Bartosz Golaszewski wrote:
> On Tue, 9 Jul 2024 at 15:05, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>>
>> Add the tlmm driver support for QCS9100 platform.
>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>> platform use non-SCMI resource. In the future, the SA8775p platform will
>> move to use SCMI resources and it will have new sa8775p-related device
>> tree. Consequently, introduce "qcom,qcs9100-tlmm" to the pinctrl device
>> match table.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   drivers/pinctrl/qcom/pinctrl-sa8775p.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sa8775p.c b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
>> index 5459c0c681a2..4687e11dfe75 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-sa8775p.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
>> @@ -1519,6 +1519,7 @@ static int sa8775p_pinctrl_probe(struct platform_device *pdev)
>>   }
>>
>>   static const struct of_device_id sa8775p_pinctrl_of_match[] = {
>> +       { .compatible = "qcom,qcs9100-tlmm", },
>>          { .compatible = "qcom,sa8775p-tlmm", },
>>          { },
>>   };
>>
>> --
>> 2.25.1
>>
> 
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore the current patche here.
Thank you for your input.

-- 
Thx and BRs,
Tengfei Fan