* drivers/pinctrl/sh-pfc/pfc-sh7734.c multiple define of TCLK1_B
@ 2019-10-17 11:54 Ben Dooks
2019-10-17 13:14 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2019-10-17 11:54 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Walleij, linux-renesas-soc,
linux-gpio@vger.kernel.org
drivers/pinctrl/sh-pfc/pfc-sh7734.c hsa TCLK1_B defined twice.
Not sure how to fix, so reporting it here:
1453 GPIO_FN(RD_WR), GPIO_FN(TCLK1_B),
1454 GPIO_FN(EX_WAIT0), GPIO_FN(TCLK1_B),
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: drivers/pinctrl/sh-pfc/pfc-sh7734.c multiple define of TCLK1_B
2019-10-17 11:54 drivers/pinctrl/sh-pfc/pfc-sh7734.c multiple define of TCLK1_B Ben Dooks
@ 2019-10-17 13:14 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-10-17 13:14 UTC (permalink / raw)
To: Ben Dooks
Cc: Geert Uytterhoeven, Linus Walleij, Linux-Renesas,
linux-gpio@vger.kernel.org
Hi Ben,
On Thu, Oct 17, 2019 at 1:54 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> drivers/pinctrl/sh-pfc/pfc-sh7734.c hsa TCLK1_B defined twice.
> Not sure how to fix, so reporting it here:
>
> 1453 GPIO_FN(RD_WR), GPIO_FN(TCLK1_B),
> 1454 GPIO_FN(EX_WAIT0), GPIO_FN(TCLK1_B),
Thanks, nice catch!
Looks like (a) someone accidentally jumped to the wrong row in the
datasheet when entering this, and (b) we need more runtime checks to
catch bugs like this.
Will fix...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-17 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-17 11:54 drivers/pinctrl/sh-pfc/pfc-sh7734.c multiple define of TCLK1_B Ben Dooks
2019-10-17 13:14 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).