From: Kevin Strasser <strassek@engr.orst.edu>
To: Michael Brunner <mibru@gmx.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Darren Hart <dvhart@linux.intel.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Chris Healy <chealy@imsco-us.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] gpio: Fix bit masking in Kontron PLD GPIO driver
Date: Sat, 10 Aug 2013 15:12:32 -0700 [thread overview]
Message-ID: <20130810221232.GD18039@flip3.engr.oregonstate.edu> (raw)
In-Reply-To: <20130809173326.75aed3b6@mail.gmx.de>
On Fri, Aug 09, 2013 at 05:33:26PM +0200, Michael Brunner wrote:
> This patch fixes the bit masking within the GPIO driver. The masking is
> basically done twice which causes the wrong GPIOs to be addressed.
>
> Signed-off-by: Michael Brunner <michael.brunner@kontron.com>
Acked-by: Kevin Strasser <strassek@engr.orst.edu>
> ---
> drivers/gpio/gpio-kempld.c | 24 +++++++++---------------
> 1 file changed, 9 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpio/gpio-kempld.c b/drivers/gpio/gpio-kempld.c
> index d3ed563..6118b66 100644
> --- a/drivers/gpio/gpio-kempld.c
> +++ b/drivers/gpio/gpio-kempld.c
> @@ -46,9 +46,9 @@ static void kempld_gpio_bitop(struct kempld_device_data *pld,
>
> status = kempld_read8(pld, reg);
> if (val)
> - status |= (1 << bit);
> + status |= KEMPLD_GPIO_MASK(bit);
> else
> - status &= ~(1 << bit);
> + status &= ~KEMPLD_GPIO_MASK(bit);
> kempld_write8(pld, reg, status);
> }
>
> @@ -60,7 +60,7 @@ static int kempld_gpio_get_bit(struct kempld_device_data *pld, u8 reg, u8 bit)
> status = kempld_read8(pld, reg);
> kempld_release_mutex(pld);
>
> - return !!(status & (1 << bit));
> + return !!(status & KEMPLD_GPIO_MASK(bit));
> }
>
> static int kempld_gpio_get(struct gpio_chip *chip, unsigned offset)
> @@ -69,8 +69,7 @@ static int kempld_gpio_get(struct gpio_chip *chip, unsigned offset)
> = container_of(chip, struct kempld_gpio_data, chip);
> struct kempld_device_data *pld = gpio->pld;
>
> - return kempld_gpio_get_bit(pld, KEMPLD_GPIO_LVL_NUM(offset),
> - KEMPLD_GPIO_MASK(offset));
> + return kempld_gpio_get_bit(pld, KEMPLD_GPIO_LVL_NUM(offset), offset);
> }
>
> static void kempld_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
> @@ -80,8 +79,7 @@ static void kempld_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
> struct kempld_device_data *pld = gpio->pld;
>
> kempld_get_mutex(pld);
> - kempld_gpio_bitop(pld, KEMPLD_GPIO_LVL_NUM(offset),
> - KEMPLD_GPIO_MASK(offset), value);
> + kempld_gpio_bitop(pld, KEMPLD_GPIO_LVL_NUM(offset), offset, value);
> kempld_release_mutex(pld);
> }
>
> @@ -92,8 +90,7 @@ static int kempld_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
> struct kempld_device_data *pld = gpio->pld;
>
> kempld_get_mutex(pld);
> - kempld_gpio_bitop(pld, KEMPLD_GPIO_DIR_NUM(offset),
> - KEMPLD_GPIO_MASK(offset), 0);
> + kempld_gpio_bitop(pld, KEMPLD_GPIO_DIR_NUM(offset), offset, 0);
> kempld_release_mutex(pld);
>
> return 0;
> @@ -107,10 +104,8 @@ static int kempld_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
> struct kempld_device_data *pld = gpio->pld;
>
> kempld_get_mutex(pld);
> - kempld_gpio_bitop(pld, KEMPLD_GPIO_LVL_NUM(offset),
> - KEMPLD_GPIO_MASK(offset), value);
> - kempld_gpio_bitop(pld, KEMPLD_GPIO_DIR_NUM(offset),
> - KEMPLD_GPIO_MASK(offset), 1);
> + kempld_gpio_bitop(pld, KEMPLD_GPIO_LVL_NUM(offset), offset, value);
> + kempld_gpio_bitop(pld, KEMPLD_GPIO_DIR_NUM(offset), offset, 1);
> kempld_release_mutex(pld);
>
> return 0;
> @@ -122,8 +117,7 @@ static int kempld_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
> = container_of(chip, struct kempld_gpio_data, chip);
> struct kempld_device_data *pld = gpio->pld;
>
> - return kempld_gpio_get_bit(pld, KEMPLD_GPIO_DIR_NUM(offset),
> - KEMPLD_GPIO_MASK(offset));
> + return kempld_gpio_get_bit(pld, KEMPLD_GPIO_DIR_NUM(offset), offset);
> }
>
> static int kempld_gpio_pincount(struct kempld_device_data *pld)
next prev parent reply other threads:[~2013-08-10 22:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 15:33 [PATCH] gpio: Fix bit masking in Kontron PLD GPIO driver Michael Brunner
2013-08-09 19:25 ` Guenter Roeck
2013-08-10 22:12 ` Kevin Strasser [this message]
2013-08-16 15:09 ` Linus Walleij
2013-08-16 15:51 ` Guenter Roeck
2013-08-16 15:58 ` Linus Walleij
2013-08-16 15:59 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130810221232.GD18039@flip3.engr.oregonstate.edu \
--to=strassek@engr.orst.edu \
--cc=chealy@imsco-us.com \
--cc=dvhart@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mibru@gmx.de \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).