Re: [PATCH] emev2: GPIOLIB: Enable support for OF

[Simon Horman <horms@verge.net.au>]

[ CC Magnus ]

On Mon, Sep 02, 2013 at 04:44:55PM +0100, Ian Molton wrote:
> EMEV2 is now a DT platform, however the GPIO driver cannot be used
> from a DT file since it does not fill out the of_node field in its
> gpio_chip structure.
> 
> Signed-off-by: Ian Molton <ian.molton@codethink.co.uk>

I have no objections to this.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>


> ---
>  drivers/gpio/Kconfig   |    2 +-
>  drivers/gpio/gpio-em.c |    1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index b2450ba..58e043d 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -129,7 +129,7 @@ config GPIO_IT8761E
>  
>  config GPIO_EM
>  	tristate "Emma Mobile GPIO"
> -	depends on ARM
> +	depends on ARM && OF_GPIO
>  	help
>  	  Say yes here to support GPIO on Renesas Emma Mobile SoCs.
>  
> diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
> index 5cba855..279821e 100644
> --- a/drivers/gpio/gpio-em.c
> +++ b/drivers/gpio/gpio-em.c
> @@ -303,6 +303,7 @@ static int em_gio_probe(struct platform_device *pdev)
>  	}
>  
>  	gpio_chip = &p->gpio_chip;
> +	gpio_chip->of_node = pdev->dev.of_node;
>  	gpio_chip->direction_input = em_gio_direction_input;
>  	gpio_chip->get = em_gio_get;
>  	gpio_chip->direction_output = em_gio_direction_output;
> -- 
> 1.7.10.4
>