From: Felipe Balbi <balbi@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: George Cherian <george.cherian@ti.com>,
balbi@ti.com,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Linus Walleij <linus.walleij@linaro.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: PCF857x and 16-bit GPIO expanders
Date: Thu, 19 Sep 2013 07:49:04 -0500 [thread overview]
Message-ID: <20130919124903.GC26101@radagast> (raw)
In-Reply-To: <523AEFD1.8000109@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2798 bytes --]
Hi,
On Thu, Sep 19, 2013 at 07:36:33AM -0500, Nishanth Menon wrote:
> On 09/19/2013 07:20 AM, George Cherian wrote:
> > On 9/19/2013 5:37 PM, Nishanth Menon wrote:
> >> On 09/19/2013 03:13 AM, George Cherian wrote:
> >>> On 9/18/2013 11:06 PM, Felipe Balbi wrote:
> >>>> Hi,
> >>>>
> >>>> On Wed, Sep 18, 2013 at 07:18:04PM +0200, Laurent Pinchart wrote:
> >>>>> On Wednesday 18 September 2013 13:16:27 Linus Walleij wrote:
> >>>>>> On Tue, Sep 17, 2013 at 9:07 PM, Felipe Balbi <balbi@ti.com> wrote:
> >>>>>>> has anyone ever successfully using gpio-pcf857x.c driver with 16-bit
> >>>>>>> gpio expanders ? We're having some issues here where toggling the last
> >>>>>>> gpio pin (gpio 15) on a PCF8575 device causes platform to hang and I
> >>>>>>> can't come up with any explanation of why would it hang...
> >>>>>> Bouncing the question to George, Laurent and Kuninori...
> >>>>> I've got a board with a PCF8575 chip, but it uses I/Os 8 to 14 only as far as
> >>>>> I know.
> >>>>>
> >>>>> I can try toggling I/O 15, but that will need to wait until next week as I'm
> >>>>> currently travelling without access to the hardware.
> >>>> alright, that'd help me a lot :-) Just want to make sure if we're having
> >>>> a board issue, or PCF8575 is a bit screwy ;-)
> >>> Is it on dra7x-evm if so which pcf device (i2c address)?
> >>> The pins i were interested were only 1 and 2 I never tried pin 15.
> >>>
> >>> Just tried toggling through sysfs and it works for me.
> >> When I look at the data sheet for PCF8575[1] Page 7, Figure 4 Write
> >> mode (output)
> >> I see the data writes are of the order:
> >> I2c 1's byte: address
> >> I2c 2'nd byte:P[7-0]
> >> I2c 3rd byte:P[17-10]
> >
> > I read it as an octal numbering.
> >> Note: bits 8,9 are missing not supported.
> >
> > In octal there is no 8 and 9
>
> Where is octal coming into play here? P8 and 9 does not exist as per
> the data sheet -> look at the pinout on page 1[1] ->P00-P17 this is
> exactly what is described on page 2[1]:
> "The number of data bytes that can be sent successively is not limited
> After every two bytes, the previous data is overwritten. When the
> PCF8575 receives the pairs of data bytes, the first byte is referred
> to as P07 – P00 and the second byte as P17 – P10. The third byte
> is referred to as P07 – P00, the fourth byte as P17 – P10, and so
> on"
>
> For someone reading schematics and setting up the P15, if the person
> uses gpios = <&PCF8575 15 OF_GPIO_HIGH>; this will result in offset =
> 15, and as a result 0x80 will be send in byte 3, which from h/w point
> of view is P13 which could be controlling something weird!
you missed one detail only. I said GPIO15, not P15 :-) GPIO15 on that
device is P17 ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-19 12:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 19:07 PCF857x and 16-bit GPIO expanders Felipe Balbi
2013-09-18 11:16 ` Linus Walleij
2013-09-18 17:18 ` Laurent Pinchart
2013-09-18 17:36 ` Felipe Balbi
2013-09-19 8:13 ` George Cherian
2013-09-19 12:07 ` Nishanth Menon
2013-09-19 12:20 ` George Cherian
2013-09-19 12:36 ` Nishanth Menon
2013-09-19 12:49 ` Felipe Balbi [this message]
2013-09-19 12:37 ` Mark Jackson
2013-09-19 12:44 ` Felipe Balbi
[not found] ` <523AF73D.5010106@ti.com>
2013-09-19 13:10 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919124903.GC26101@radagast \
--to=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).