From: Baruch Siach <baruch@tkos.co.il>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH] gpio: pl061: drop references to "virtual" IRQ
Date: Sat, 12 Oct 2013 21:59:02 +0300 [thread overview]
Message-ID: <20131012185901.GA4276@tarshish> (raw)
In-Reply-To: <1381513327-7787-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
On Fri, Oct 11, 2013 at 07:42:07PM +0200, Linus Walleij wrote:
> Rename the argument "virq" to just "irq", this IRQ isn't any
> more "virtual" than any other Linux IRQ number, we use "hwirq"
> for the actual hw-numbers, "virq" is just bogus.
>
> Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Baruch Siach <baruch@tkos.co.il>
baruch
> ---
> drivers/gpio/gpio-pl061.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
> index 4274e2e..f22f7f3 100644
> --- a/drivers/gpio/gpio-pl061.c
> +++ b/drivers/gpio/gpio-pl061.c
> @@ -238,15 +238,15 @@ static struct irq_chip pl061_irqchip = {
> .irq_set_type = pl061_irq_type,
> };
>
> -static int pl061_irq_map(struct irq_domain *d, unsigned int virq,
> - irq_hw_number_t hw)
> +static int pl061_irq_map(struct irq_domain *d, unsigned int irq,
> + irq_hw_number_t hwirq)
> {
> struct pl061_gpio *chip = d->host_data;
>
> - irq_set_chip_and_handler_name(virq, &pl061_irqchip, handle_simple_irq,
> + irq_set_chip_and_handler_name(irq, &pl061_irqchip, handle_simple_irq,
> "pl061");
> - irq_set_chip_data(virq, chip);
> - irq_set_irq_type(virq, IRQ_TYPE_NONE);
> + irq_set_chip_data(irq, chip);
> + irq_set_irq_type(irq, IRQ_TYPE_NONE);
>
> return 0;
> }
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2013-10-12 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 17:42 [PATCH] gpio: pl061: drop references to "virtual" IRQ Linus Walleij
2013-10-12 18:59 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131012185901.GA4276@tarshish \
--to=baruch@tkos.co.il \
--cc=acourbot@nvidia.com \
--cc=haojian.zhuang@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).