From: Jean Delvare <jdelvare@suse.de>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: Modular gpio-lynxpoint
Date: Sat, 19 Oct 2013 20:57:02 +0200 [thread overview]
Message-ID: <20131019205702.4bfba569@endymion.delvare> (raw)
Hi Mathias,
What is the rationale for CONFIG_GPIO_LYNXPOINT being a bool? Device
drivers that can't be built as modules are a pain for distribution
kernels. And I tried building gpio-lynxpoint as a module and it worked
(although I can't run-time test it.)
Any problem with the patch below?
From: Jean Delvare <jdelvare@suse.de>
Subject: gpio-lynxpoint: Allow building as a module
Change CONFIG_GPIO_LYNXPOINT from bool to tristate so that the
gpio-lynxpoint driver can be built as a module.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.12-rc5.orig/drivers/gpio/Kconfig 2013-10-19 18:25:13.521488669 +0200
+++ linux-3.12-rc5/drivers/gpio/Kconfig 2013-10-19 19:31:43.527324443 +0200
@@ -344,7 +344,7 @@ config GPIO_GE_FPGA
board computers.
config GPIO_LYNXPOINT
- bool "Intel Lynxpoint GPIO support"
+ tristate "Intel Lynxpoint GPIO support"
depends on ACPI && X86
select IRQ_DOMAIN
help
--
Jean Delvare
Suse L3 Support
next reply other threads:[~2013-10-19 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 18:57 Jean Delvare [this message]
2013-10-21 7:50 ` Modular gpio-lynxpoint Mathias Nyman
2013-10-28 22:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131019205702.4bfba569@endymion.delvare \
--to=jdelvare@suse.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).