* Modular gpio-lynxpoint
@ 2013-10-19 18:57 Jean Delvare
2013-10-21 7:50 ` Mathias Nyman
2013-10-28 22:06 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Jean Delvare @ 2013-10-19 18:57 UTC (permalink / raw)
To: Mathias Nyman; +Cc: linux-gpio, Linus Walleij
Hi Mathias,
What is the rationale for CONFIG_GPIO_LYNXPOINT being a bool? Device
drivers that can't be built as modules are a pain for distribution
kernels. And I tried building gpio-lynxpoint as a module and it worked
(although I can't run-time test it.)
Any problem with the patch below?
From: Jean Delvare <jdelvare@suse.de>
Subject: gpio-lynxpoint: Allow building as a module
Change CONFIG_GPIO_LYNXPOINT from bool to tristate so that the
gpio-lynxpoint driver can be built as a module.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.12-rc5.orig/drivers/gpio/Kconfig 2013-10-19 18:25:13.521488669 +0200
+++ linux-3.12-rc5/drivers/gpio/Kconfig 2013-10-19 19:31:43.527324443 +0200
@@ -344,7 +344,7 @@ config GPIO_GE_FPGA
board computers.
config GPIO_LYNXPOINT
- bool "Intel Lynxpoint GPIO support"
+ tristate "Intel Lynxpoint GPIO support"
depends on ACPI && X86
select IRQ_DOMAIN
help
--
Jean Delvare
Suse L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Modular gpio-lynxpoint
2013-10-19 18:57 Modular gpio-lynxpoint Jean Delvare
@ 2013-10-21 7:50 ` Mathias Nyman
2013-10-28 22:06 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Mathias Nyman @ 2013-10-21 7:50 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-gpio, Linus Walleij
On 10/19/2013 09:57 PM, Jean Delvare wrote:
> Hi Mathias,
>
> What is the rationale for CONFIG_GPIO_LYNXPOINT being a bool? Device
> drivers that can't be built as modules are a pain for distribution
> kernels. And I tried building gpio-lynxpoint as a module and it worked
> (although I can't run-time test it.)
>
For Lynxpoint I think it only was about competition for port respources.
IO port ranges used for gpios were specified in ACPI tables both in the
gpio device, and as a part of a motherboard device. Pnpacpi code
reserved all the IO port ranges in the motherboard device before the
gpio driver.
For Baytrail the gpio driver can handle hw reduced ACPI events,
(basically ACPI telling operating system it wants an ACPI event run
when a certain gpio interrupt is triggered, and it wants the OS gpio
driver to do it. If this feature is used then I think it's better to
build in the driver.
I'm not sure if there is a resource conflict anymore in the Lynxpoint
case. Should be checked, and fix it properly on the pnpacpi side.
Otherwise I guess Lynxpoint could be built as a module
-Mathias
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Modular gpio-lynxpoint
2013-10-19 18:57 Modular gpio-lynxpoint Jean Delvare
2013-10-21 7:50 ` Mathias Nyman
@ 2013-10-28 22:06 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-10-28 22:06 UTC (permalink / raw)
To: Jean Delvare; +Cc: Mathias Nyman, linux-gpio@vger.kernel.org
On Sat, Oct 19, 2013 at 8:57 PM, Jean Delvare <jdelvare@suse.de> wrote:
> Any problem with the patch below?
Looks OK to me but I won't apply it until after the merge window, so please
send the patch after that.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-28 22:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-19 18:57 Modular gpio-lynxpoint Jean Delvare
2013-10-21 7:50 ` Mathias Nyman
2013-10-28 22:06 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).